Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form with forwardRef typescript #16242

Merged
merged 2 commits into from Apr 23, 2019

Conversation

Projects
None yet
4 participants
@zombieJ
Copy link
Member

commented Apr 22, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #16229

馃挕 Solution

Update typescript definition

馃摑 Changelog

Fix Form with forwardRef typescript definition.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

zombieJ added some commits Apr 22, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Apr 22, 2019

@zombieJ zombieJ requested review from yesmeck and afc163 Apr 22, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 22, 2019

Deploy preview for ant-design ready!

Built with commit 771423b

https://deploy-preview-16242--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 22, 2019

Codecov Report

Merging #16242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16242   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         252      252           
  Lines        6741     6741           
  Branches     1950     1950           
=======================================
  Hits         6422     6422           
  Misses        318      318           
  Partials        1        1
Impacted Files Coverage 螖
components/form/Form.tsx 88.88% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9fd27e0...771423b. Read the comment docs.

@zombieJ zombieJ merged commit da9cef9 into master Apr 23, 2019

30 of 32 checks passed

Header rules No header rules processed
Details
Pages changed 214 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 5 issues resolved and 1 introduced
Details
codecov/patch Coverage not affected when comparing 9fd27e0...771423b
Details
codecov/project 95.26% remains the same compared to 9fd27e0
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot removed the PR: unreviewed label Apr 23, 2019

@delete-merged-branch delete-merged-branch bot deleted the form-ts branch Apr 23, 2019

@pr-triage pr-triage bot added the PR: merged label Apr 23, 2019

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

杩欎釜鏄笉鏄病鏈夊彂鐗堟湰锛

@DiamondYuan DiamondYuan referenced this pull request Apr 24, 2019

Closed

typescript form break in 3.16.5 #16284

0 of 1 task complete
@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Apr 25, 2019

杩樻病鍙

sbusch added a commit to sbusch/ant-design that referenced this pull request Apr 25, 2019

fix: Form with forwardRef typescript (ant-design#16242)
* update form typescript define with forawardRef

* add ts test

(cherry picked from commit da9cef9)
@hsulei

This comment has been minimized.

Copy link

commented Apr 25, 2019

杩戞湡浼氬彂鍚楋紵

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2019

姣忓懆鏈彂鐗堟湰

@afc163

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

will close #16284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.