Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove active style from disabled Switch #16251

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
2 participants
@atomoo
Copy link
Contributor

commented Apr 23, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #16246

馃挕 Solution

change &:active::after to &:not(&-disabled):active::after

馃摑 Changelog

  • English Changelog:
    remove the active style of disabled Switch
  • Chinese Changelog (optional):
    鍘绘帀浜嗗け鏁堢姸鎬佷笅Switch鐨刟ctive鏍峰紡

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 23, 2019

@atomoo atomoo referenced this pull request Apr 23, 2019

Closed

Should a disabled Switch has :active style? #16246

1 of 1 task complete
@netlify

This comment has been minimized.

Copy link

commented Apr 23, 2019

Deploy preview for ant-design ready!

Built with commit b5291f0

https://deploy-preview-16251--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 23, 2019

Codecov Report

Merging #16251 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16251      +/-   ##
==========================================
- Coverage   95.31%    95.2%   -0.11%     
==========================================
  Files         252      252              
  Lines        6741     6741              
  Branches     1962     1962              
==========================================
- Hits         6425     6418       -7     
- Misses        315      322       +7     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/form/FormItem.tsx 96.51% <0%> (-2.33%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update da9cef9...b5291f0. Read the comment docs.

@afc163 afc163 changed the title remove active style from disabled Switch fix: remove active style from disabled Switch Apr 23, 2019

@afc163 afc163 merged commit 35bb93c into ant-design:master Apr 23, 2019

27 of 30 checks passed

codecov/project 95.2% (-0.11%) compared to da9cef9
Details
Header rules No header rules processed
Details
Pages changed 212 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No code changes detected
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 5 issues resolved and 1 introduced
Details
codecov/patch Coverage not affected when comparing da9cef9...b5291f0
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 23, 2019

@atomoo atomoo deleted the atomoo:fix-switch-active-style branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.