Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal title break word #16267

Merged
merged 1 commit into from Apr 24, 2019

Conversation

Projects
None yet
3 participants
@yoyo837
Copy link
Contributor

commented Apr 24, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

馃挕 Solution

馃摑 Changelog

Modal title style support break word.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 24, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 24, 2019

Deploy preview for ant-design ready!

Built with commit b2bad3b

https://deploy-preview-16267--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #16267 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16267      +/-   ##
==========================================
+ Coverage   95.25%   95.26%   +0.01%     
==========================================
  Files         252      252              
  Lines        6741     6741              
  Branches     1964     1962       -2     
==========================================
+ Hits         6421     6422       +1     
+ Misses        319      318       -1     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/form/FormItem.tsx 98.83% <0%> (+2.32%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 197c424...b2bad3b. Read the comment docs.

2 similar comments
@codecov

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #16267 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16267      +/-   ##
==========================================
+ Coverage   95.25%   95.26%   +0.01%     
==========================================
  Files         252      252              
  Lines        6741     6741              
  Branches     1964     1962       -2     
==========================================
+ Hits         6421     6422       +1     
+ Misses        319      318       -1     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/form/FormItem.tsx 98.83% <0%> (+2.32%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 197c424...b2bad3b. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Apr 24, 2019

Codecov Report

Merging #16267 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16267      +/-   ##
==========================================
+ Coverage   95.25%   95.26%   +0.01%     
==========================================
  Files         252      252              
  Lines        6741     6741              
  Branches     1964     1962       -2     
==========================================
+ Hits         6421     6422       +1     
+ Misses        319      318       -1     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/form/FormItem.tsx 98.83% <0%> (+2.32%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 197c424...b2bad3b. Read the comment docs.

@zombieJ zombieJ merged commit 1f142c0 into ant-design:master Apr 24, 2019

28 of 31 checks passed

Semantic Pull Request add a semantic commit or PR title
Details
Header rules No header rules processed
Details
Pages changed 212 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No code changes detected
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 5 issues resolved and 2 introduced
Details
codecov/patch Coverage not affected when comparing 197c424...b2bad3b
Details
codecov/project 95.26% (+0.01%) compared to 197c424
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 24, 2019

@@ -30,6 +30,7 @@
font-weight: 500;
font-size: @font-size-lg;
line-height: 22px;
word-wrap: break-word;

This comment has been minimized.

Copy link
@afc163

afc163 Apr 24, 2019

Member

Why adding this? break-word should not be default style.

This comment has been minimized.

Copy link
@yoyo837

yoyo837 Apr 24, 2019

Author Contributor

Did I break something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.