Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

modal title break word #16267

Merged
merged 1 commit into from Apr 24, 2019
Merged

modal title break word #16267

merged 1 commit into from Apr 24, 2019

Conversation

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Apr 24, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

馃挕 Solution

馃摑 Changelog

Modal title style support break word.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify
Copy link

@netlify netlify bot commented Apr 24, 2019

Deploy preview for ant-design ready!

Built with commit b2bad3b

https://deploy-preview-16267--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Apr 24, 2019

Codecov Report

Merging #16267 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16267      +/-   ##
==========================================
+ Coverage   95.25%   95.26%   +0.01%     
==========================================
  Files         252      252              
  Lines        6741     6741              
  Branches     1964     1962       -2     
==========================================
+ Hits         6421     6422       +1     
+ Misses        319      318       -1     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/form/FormItem.tsx 98.83% <0%> (+2.32%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 197c424...b2bad3b. Read the comment docs.

2 similar comments
@codecov
Copy link

@codecov codecov bot commented Apr 24, 2019

Codecov Report

Merging #16267 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16267      +/-   ##
==========================================
+ Coverage   95.25%   95.26%   +0.01%     
==========================================
  Files         252      252              
  Lines        6741     6741              
  Branches     1964     1962       -2     
==========================================
+ Hits         6421     6422       +1     
+ Misses        319      318       -1     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/form/FormItem.tsx 98.83% <0%> (+2.32%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 197c424...b2bad3b. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented Apr 24, 2019

Codecov Report

Merging #16267 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16267      +/-   ##
==========================================
+ Coverage   95.25%   95.26%   +0.01%     
==========================================
  Files         252      252              
  Lines        6741     6741              
  Branches     1964     1962       -2     
==========================================
+ Hits         6421     6422       +1     
+ Misses        319      318       -1     
  Partials        1        1
Impacted Files Coverage 螖
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍
components/form/FormItem.tsx 98.83% <0%> (+2.32%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 197c424...b2bad3b. Read the comment docs.

@zombieJ zombieJ merged commit 1f142c0 into ant-design:master Apr 24, 2019
30 of 31 checks passed
@@ -30,6 +30,7 @@
font-weight: 500;
font-size: @font-size-lg;
line-height: 22px;
word-wrap: break-word;
Copy link
Member

@afc163 afc163 Apr 24, 2019

Why adding this? break-word should not be default style.

Copy link
Contributor Author

@yoyo837 yoyo837 Apr 24, 2019

Did I break something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants