Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tree checkbox animation not correct #16272

Merged
merged 4 commits into from Apr 24, 2019
Merged

fix: Tree checkbox animation not correct #16272

merged 4 commits into from Apr 24, 2019

Conversation

DiamondYuan
Copy link
Contributor

@DiamondYuan DiamondYuan commented Apr 24, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

close #16259

📝 Changelog

  • English Changelog:
  • Chinese Changelog (optional):

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Apr 24, 2019

Deploy preview for ant-design ready!

Built with commit 12e472d

https://deploy-preview-16272--ant-design.netlify.com

@DiamondYuan
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #16272 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16272      +/-   ##
==========================================
- Coverage   95.31%   95.26%   -0.05%     
==========================================
  Files         253      252       -1     
  Lines        6743     6741       -2     
  Branches     1964     1927      -37     
==========================================
- Hits         6427     6422       -5     
- Misses        315      318       +3     
  Partials        1        1
Impacted Files Coverage Δ
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️
components/list/Item.tsx 100% <0%> (ø) ⬆️
components/_util/reactNode.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f142c0...12e472d. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Apr 24, 2019

This failed Checkbox animation:
Kapture 2019-04-24 at 13 51 54

@zombieJ
Copy link
Member

zombieJ commented Apr 24, 2019

很多地方用了 checkbox/style/mixin.less,看看改哪个最方便些。

@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Apr 24, 2019

很多地方用了 checkbox/style/mixin.less,看看改哪个最方便些。

全局搜了一下,没注意文件名我就改了。🤦‍♂️

在 tree 里面覆盖了样式。

image

@DiamondYuan
Copy link
Contributor Author

@zombieJ 可以了

@zombieJ
Copy link
Member

zombieJ commented Apr 24, 2019

Tree 还是比正常的大了一圈:
Kapture 2019-04-24 at 16 24 05
Kapture 2019-04-24 at 16 25 06

@DiamondYuan
Copy link
Contributor Author

DiamondYuan commented Apr 24, 2019

OK了

@zombieJ zombieJ merged commit b3bea96 into master Apr 24, 2019
@afc163 afc163 deleted the fix#16259 branch April 24, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree checkbox animation not correct
2 participants