Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Breadcrumb support DropDown #16315

Merged
merged 10 commits into from Apr 28, 2019
Merged

feat: Breadcrumb support DropDown #16315

merged 10 commits into from Apr 28, 2019

Conversation

@chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Apr 25, 2019

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ‘» What's the background?

#16287

πŸ’‘ Solution

image

πŸ“ Changelog

  • Breadcrumb support overlay props.
  • Breadcrumb ζ”―ζŒ overlay ε±žζ€§

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/breadcrumb/demo/basic.md
View rendered components/breadcrumb/demo/overlay.md
View rendered components/breadcrumb/demo/router.md
View rendered components/breadcrumb/index.en-US.md
View rendered components/breadcrumb/index.zh-CN.md
View rendered components/button/demo/basic.md
View rendered components/button/demo/block.md
View rendered components/button/demo/disabled.md
View rendered components/button/demo/ghost.md
View rendered components/button/demo/size.md
View rendered components/button/index.en-US.md
View rendered components/button/index.zh-CN.md

@chenshuai2144 chenshuai2144 changed the base branch from master to feature Apr 25, 2019
@netlify
Copy link

@netlify netlify bot commented Apr 25, 2019

Deploy preview for ant-design ready!

Built with commit 673a818

https://deploy-preview-16315--ant-design.netlify.com

Loading

@codecov
Copy link

@codecov codecov bot commented Apr 25, 2019

Codecov Report

Merging #16315 into feature will decrease coverage by 0.04%.
The diff coverage is 96.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #16315      +/-   ##
===========================================
- Coverage     95.3%   95.25%   -0.05%     
===========================================
  Files          256      256              
  Lines         6832     6845      +13     
  Branches      1972     1988      +16     
===========================================
+ Hits          6511     6520       +9     
- Misses         320      324       +4     
  Partials         1        1
Impacted Files Coverage Ξ”
components/breadcrumb/BreadcrumbItem.tsx 100% <100%> (ΓΈ) ⬆️
components/breadcrumb/Breadcrumb.tsx 95.83% <94.73%> (-1.73%) ⬇️
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 9d5f613...673a818. Read the comment docs.

Loading

components/breadcrumb/Breadcrumb.tsx Outdated Show resolved Hide resolved
Loading
components/breadcrumb/demo/overlay.md Outdated Show resolved Hide resolved
Loading
components/breadcrumb/demo/overlay.md Outdated Show resolved Hide resolved
Loading
components/breadcrumb/BreadcrumbItem.tsx Outdated Show resolved Hide resolved
Loading
components/breadcrumb/BreadcrumbItem.tsx Outdated Show resolved Hide resolved
Loading
@zombieJ zombieJ changed the title Feat: Breadcrumb support DropDown feat: Breadcrumb support DropDown Apr 28, 2019
@zombieJ zombieJ merged commit 34f24a8 into feature Apr 28, 2019
31 checks passed
Loading
@delete-merged-branch delete-merged-branch bot deleted the breadcrumb-menu branch Apr 28, 2019
chenshuai2144 added a commit that referenced this issue May 6, 2019
* use ul in list

* update snapshot

* update comment

* feat: TreeSelect support `showSearch` in multiple mode (#15933)

* update rc-tree-select

* typo

* update desc & snapshot

* update desc & snapshot

* check default showSearch

* feat: table customizing variable (#15971)

* feat: added table selected row color variable

* fix: @table-selected-row-color default is inherit

* feat: Upload support customize previewFile (#15984)

* support preview file

* use promise

* dealy load

* use canvas of render

* use domHook of test

* update demo

* add snapshot

* update types

* update testcase

* feat: form customizing variables (#15954)

* fix: added styling form input background-color

* feat: added '@form-warning-input-bg' variable

* feat: added '@form-error-input-bg' variable

* use li wrap with comment

* feat: Support append theme less file with less-variable (#16118)

* add override

* add override support

* update doc

* feat: dropdown support set right icon

* docs: update doc of dropdown component

* style: format dropdown-button.md

* test: update updateSnapshot

* style: format dropdown-button.md

* test: update updateSnapshot

* test: update updateSnapshot

* style: change style of dropdown-button demo

* fix: fix document table order

* feat: Support SkeletonAvatarProps.size accept number (#16078) (#16128)

* chore:update style of demo

* feat: Notification functions accept top, bottom and getContainer as arguments

* drawer: add afterVisibleChange

* rm onVisibleChange

* update

* feat: πŸ‡­πŸ‡· hr_HR locale (#16258)

* Added Croatian locale

* fixed lint error

* βœ… Add test cases for hr_HR

* πŸ“ update i18n documentation

* feat:  add `htmlFor` in Form.Item (#16278)

* add htmlFor in Form.Item

* update doc

* feat: Button support `link` type (#16289)

close #15892

* feat: Add Timeline.Item.position (#16148) (#16193)

* fix: Timeline.pendingDot interface documentation there is a small problem (#16177)

* feat: Add Timeline.Item.position (#16148)

* doc: add version infomation for Timeline.Item.position

* refactor: Update Tree & TreeSelect deps (#16330)

* use CSSMotion

* update snapshot

* feat: Collapse support `expandIconPosition` (#16365)

* update doc

* support expandIconPosition

* update snapshot

* feat: Breadcrumb  support DropDown (#16315)

* breadcrumbs support drop down menu

* update doc

* add require less

* fix test

* fix md doc

* less code

* fix  style warning

* update snap

* add children render test

* feat: TreeNode support checkable

* feat: add optional to support top and left slick dots (#16186) (#16225)

* add optional to support top and left slick dots

* update carousel snapshot

* Update doc, add placement demo

* update carousel placement demo snapshots

* rename dots placement to position

* update vertical as deprecated

* rename dotsPosition to dotPosition

* refine code

* add warning testcase for vertical

* remove unused warning

* update expression

* Additional test case for dotPosition

* refactor: Upgrade `rc-tree-select` to support pure React motion (#16402)

* upgrade `rc-tree-select`

* update snapshot

* 3.17.0 changelog

* fix warning

* fix review warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants