Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangePicker.renderExtraFooter() gets no args, fix TypeScript definition and clean up code #16341

Merged

Conversation

Projects
None yet
2 participants
@sbusch
Copy link
Contributor

commented Apr 26, 2019

馃 This is a ...

  • TypeScript definition update
  • Code style optimization

馃懟 What's the background?

RangeCalendar (from rc-calendar) calls renderFooter` without any arguments

This fact is correctly documented at RangePicker's documentation for renderExtraFooter but the code passes (non-existent) arguments to renderExtraFooter(). This can be confusing.

馃挕 Solution

Do not pass args to renderExtraFooter()

Fix TypeScript defs.

馃摑 Changelog

No extra changelog needed because behavior was already correctly documented.

鈽戯笍 Self Check before Merge

  • Doc is not needed (alreay correct)
  • Demo is not needed
  • TypeScript definition is updated
  • Changelog is not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 26, 2019

@sbusch sbusch changed the title RangePicker.renderFooter() gets no args, don't pass to renderExtraFooter(), fix TypeScript definition RangePicker.renderExtraFooter() gets no args, fix TypeScript definition and clean up code Apr 26, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 26, 2019

Deploy preview for ant-design ready!

Built with commit 7a514c1

https://deploy-preview-16341--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 26, 2019

Codecov Report

Merging #16341 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16341   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         253      253           
  Lines        6780     6780           
  Branches     1968     1968           
=======================================
  Hits         6460     6460           
  Misses        319      319           
  Partials        1        1
Impacted Files Coverage 螖
components/date-picker/RangePicker.tsx 94.33% <100%> (酶) 猬嗭笍
components/tooltip/index.tsx 96.38% <0%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 04001a0...7a514c1. Read the comment docs.

@afc163 afc163 merged commit 7e82ada into ant-design:master Apr 27, 2019

28 of 31 checks passed

Semantic Pull Request add a semantic commit or PR title
Details
Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 6 issues resolved and 6 introduced
Details
codecov/patch 100% of diff hit (target 95.28%)
Details
codecov/project 95.28% (+0%) compared to 04001a0
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 27, 2019

@sbusch sbusch deleted the sbusch:RangePicker-renderExtraFooter-gets-no-args branch May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.