Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Drawer wrong animation direction #16358

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Apr 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #15713

image

close #15146

image

💡 Solution

📝 Changelog

  • English Changelog: Fix Drawer wrong animation direction.
  • Chinese Changelog (optional): 修复 Drawer 组件的弹出动画闪烁的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 28, 2019

@afc163 afc163 changed the title :bug: Fix Drawer wrong animation direction fix: 🐛 Drawer wrong animation direction Apr 28, 2019

@@ -61,6 +61,7 @@ class App extends React.Component {
closable={false}
onClose={this.onClose}
visible={this.state.visible}
mask={false}

This comment has been minimized.

Copy link
@jljsj33

jljsj33 Apr 28, 2019

Member

这个不用加着,,亲。。。

This comment has been minimized.

Copy link
@afc163

afc163 Apr 28, 2019

Author Member

done

@afc163 afc163 force-pushed the fix-drawer-animation branch from 1c17af2 to 49dae1a Apr 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #16358 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16358      +/-   ##
==========================================
+ Coverage   95.28%   95.32%   +0.04%     
==========================================
  Files         253      253              
  Lines        6780     6780              
  Branches     1968     1968              
==========================================
+ Hits         6460     6463       +3     
+ Misses        319      316       -3     
  Partials        1        1
Impacted Files Coverage Δ
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7015b64...49dae1a. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Apr 28, 2019

Deploy preview for ant-design ready!

Built with commit 1c17af2

https://deploy-preview-16358--ant-design.netlify.com

@afc163

This comment has been minimized.

Copy link
Member Author

commented Apr 28, 2019

@jljsj33 还有一个问题:react-component/drawer#86

@netlify

This comment has been minimized.

Copy link

commented Apr 28, 2019

Deploy preview for ant-design ready!

Built with commit 49dae1a

https://deploy-preview-16358--ant-design.netlify.com

@afc163 afc163 merged commit 5ef2cc5 into master Apr 29, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 6 issues resolved and 6 introduced
Details
codecov/patch Coverage not affected when comparing 7015b64...49dae1a
Details
codecov/project 95.32% (+0.04%) compared to 7015b64
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot removed the PR: unreviewed label Apr 29, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-drawer-animation branch Apr 29, 2019

@pr-triage pr-triage bot added the PR: merged label Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.