Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload types #16360

Merged
merged 5 commits into from Apr 28, 2019

Conversation

Projects
None yet
4 participants
@ycjcl868
Copy link
Member

commented Apr 28, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

Close #14420.

馃挕 Solution

馃摑 Changelog

  • English Changelog:
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 28, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 28, 2019

Deploy preview for ant-design ready!

Built with commit e5c8505

https://deploy-preview-16360--ant-design.netlify.com

@zombieJ

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

Master updated. Merge and retry.

@ycjcl868 ycjcl868 force-pushed the types-upload-export branch from eedd1da to ca1332d Apr 28, 2019

@zombieJ

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

CI still failed

Nanjing
/
/

This comment has been minimized.

Copy link
@zombieJ

zombieJ Apr 28, 2019

Member

濂囨紝杩欓噷搴旇涓嶅奖鍝嶆墠瀵光︹

@ycjcl868 ycjcl868 force-pushed the types-upload-export branch from 5ab80d1 to e5c8505 Apr 28, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #16360 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16360      +/-   ##
==========================================
+ Coverage   95.28%   95.32%   +0.04%     
==========================================
  Files         253      253              
  Lines        6780     6780              
  Branches     1968     1933      -35     
==========================================
+ Hits         6460     6463       +3     
+ Misses        319      316       -3     
  Partials        1        1
Impacted Files Coverage 螖
components/upload/index.tsx 100% <酶> (酶) 猬嗭笍
components/_util/wave.tsx 88.46% <0%> (+2.88%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5469bba...e5c8505. Read the comment docs.

@zombieJ zombieJ merged commit 59856a0 into master Apr 28, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 212 new files uploaded
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat 6 issues resolved and 6 introduced
Details
codecov/patch Coverage not affected when comparing 5469bba...e5c8505
Details
codecov/project 95.32% (+0.04%) compared to 5469bba
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the types-upload-export branch Apr 28, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 28, 2019

@eruca

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

鎴戞彁浜嗕竴涓猧ssue锛岀洿鎺ヨ鍏充簡锛屾垜灏卞彂鍦ㄨ繖鎶婏紝Tree onDragEnter鐨則s鍑芥暟瀹氫箟鏈夐棶棰橈紝
OnDragEnter: AntTreeNodeMouseEvent => void, 鍙槸瀹樻柟绀轰緥浠g爜鍙婅鏄庨噷鏈変竴涓猠xpanededKeys, 鍦ㄥ畾涔夐噷娌℃湁锛岀洿鎺ユ姤閿

@ycjcl868

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

鎻愪釜 PR 鍚э紝涓轰粈涔 Tree OnDragEnter 绫诲瀷鍦ㄥ洖澶嶅湪杩欎釜 pr 閲屻

@ztplz

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2019

涓嶇鍚堣鑼冪殑鏈哄櫒浜洪兘浼氳嚜鍔ㄥ叧 鏈濂芥湁涓猳nline demo 鎴栬 repo锛岃繖涓兘鑺傜害澶ч噺鐨勬椂闂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.