Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Checkbox.Group onChange should not pass removed value #16392

Merged
merged 3 commits into from Apr 30, 2019

Conversation

Projects
None yet
3 participants
@zombieJ
Copy link
Member

commented Apr 30, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

fix #16376

馃挕 Solution

Register value for filter.

馃摑 Changelog

Fix Checkbox.Group onChange pass removed value.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 30, 2019

@zombieJ zombieJ requested a review from ztplz Apr 30, 2019

@zombieJ zombieJ requested a review from afc163 Apr 30, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 30, 2019

Deploy preview for ant-design ready!

Built with commit a54b1f7

https://deploy-preview-16392--ant-design.netlify.com

@ztplz

ztplz approved these changes Apr 30, 2019

registeredValues: [...registeredValues, value],
}));
};
cancelValue = (value: string) => {

This comment has been minimized.

Copy link
@ztplz

ztplz Apr 30, 2019

Collaborator

绌轰竴琛 涓璧蜂簡

@netlify

This comment has been minimized.

Copy link

commented Apr 30, 2019

Deploy preview for ant-design ready!

Built with commit 347ef7d

https://deploy-preview-16392--ant-design.netlify.com

@netlify

This comment has been minimized.

Copy link

commented Apr 30, 2019

Deploy preview for ant-design ready!

Built with commit 1bdf54f

https://deploy-preview-16392--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

Merging #16392 into master will decrease coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16392      +/-   ##
==========================================
- Coverage   95.32%   95.26%   -0.06%     
==========================================
  Files         253      253              
  Lines        6780     6803      +23     
  Branches     1933     1974      +41     
==========================================
+ Hits         6463     6481      +18     
- Misses        316      321       +5     
  Partials        1        1
Impacted Files Coverage 螖
components/checkbox/Group.tsx 100% <100%> (酶) 猬嗭笍
components/checkbox/Checkbox.tsx 95.83% <88.23%> (-4.17%) 猬囷笍
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1a8d5f6...1bdf54f. Read the comment docs.

@zombieJ zombieJ merged commit 7a7aa65 into master Apr 30, 2019

27 of 31 checks passed

codecov/patch 91.66% of diff hit (target 95.32%)
Details
codebeat 6 issues resolved and 7 introduced
Details
Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/project 95.26% (-0.06%) compared to 1a8d5f6
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Apr 30, 2019

@delete-merged-branch delete-merged-branch bot deleted the filter-checkbox-group branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.