Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hoist-non-react-statics compilation error #16397

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
3 participants
@ztplz
Copy link
Collaborator

commented Apr 30, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #16397

馃挕 Solution

馃摑 Changelog

  • English Changelog:
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 30, 2019

@ztplz ztplz requested review from zombieJ and afc163 Apr 30, 2019

@netlify

This comment has been minimized.

Copy link

commented Apr 30, 2019

Deploy preview for ant-design ready!

Built with commit e5d1299

https://deploy-preview-16397--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

Merging #16397 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16397   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         258      258           
  Lines        7117     7117           
  Branches     2004     2002    -2     
=======================================
  Hits         6812     6812           
  Misses        303      303           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 83c1670...e5d1299. Read the comment docs.

@ztplz

This comment has been minimized.

Copy link
Collaborator Author

commented May 1, 2019

ref: #16396

@zombieJ

This comment has been minimized.

Copy link
Member

commented May 1, 2019

We need @types/hoist-non-react-statics in deps since Form use it to calculate. ref: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-redux/package.json

@ztplz

This comment has been minimized.

Copy link
Collaborator Author

commented May 1, 2019

杩欎釜闂浜х敓鐨勫師鍥犳槸 鐢ㄦ埛鏈夊叾浠栧簱涔熶緷璧栦簡杩欎釜hoist-non-react-statics 鑰屼笖鏄3.0鍓嶇殑鐗堟湰 鑰屼笖姣攁ntd鍏堝畨瑁 hoist-non-react-statics浼氳鍦╪ode_module鐨剅oot閲 浣嗘槸antd涔熶緷璧栦簡杩欎釜 浠ヤ负宸茬粡瀹夎hoist-non-react-statics 鎵浠ユ垜浠繖涓槸鍦╝ntd杩欎釜鏂囦欢澶归噷 瀹冧細鎵句笉鍒
鎴戝幓闂釜repo鏉 浠旂粏鐪嬩竴涓

@zombieJ

This comment has been minimized.

Copy link
Member

commented May 1, 2019

杩欎釜闂浜х敓鐨勫師鍥犳槸 鈥︹

缁欏姏! 馃憤

@afc163

This comment has been minimized.

Copy link
Member

commented May 8, 2019

any progress?

@zombieJ

This comment has been minimized.

Copy link
Member

commented May 8, 2019

瀹炲湪涓嶈灏辨妸 hoist-non-react-statics 鐨勫畾涔夋嫹鍑烘潵绠椾簡锛屾湰鏉ヤ篃鍙槸鐢ㄤ簡 ts 鐨勫畾涔夌舰浜嗐

@ztplz

This comment has been minimized.

Copy link
Collaborator Author

commented May 8, 2019

杩欏氨鏄В鍐虫柟妗堝晩 鎶 hoist-non-react-statics 涔熻杩涙潵 浣嗘槸鎴戣寰楅澶栧涓簱娌″繀瑕

@zombieJ

This comment has been minimized.

Copy link
Member

commented May 9, 2019

鎴戞寚鐨勬槸鎶 ts 閲岃绠楃殑瀹氫箟鎷疯礉杩囨潵锛孎orm 閲屽叾瀹炲彧鏄敤瀹冩潵鍑忓幓涓嶉渶瑕佺殑 props銆俬oist-non-react-statics 鎴戜滑娌℃湁瀹為檯鐢ㄥ埌銆

@ztplz

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2019

閭h繖涓簱灏变笉鐢ㄥ惂 鎴戞妸hoist-non-react-statics閲岀浉鍏崇殑瀹氫箟鎼繃鏉

@buildsize

This comment has been minimized.

Copy link

commented May 9, 2019

File name Previous Size New Size Change
package-lock.json 820.75聽KB 823.49聽KB 2.74聽KB (0%)

@ztplz ztplz force-pushed the ztplz:hoist branch from eda1af4 to e5d1299 May 9, 2019

@zombieJ zombieJ merged commit 62f8924 into ant-design:master May 9, 2019

25 of 28 checks passed

Semantic Pull Request add a semantic commit or PR title
Details
Header rules No header rules processed
Details
Pages changed 213 new files uploaded
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 83c1670...e5d1299
Details
codecov/project 95.71% remains the same compared to 83c1670
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.