Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve filterDropdown typescript type #16446

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented May 7, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #16413

馃挕 Solution

馃摑 Changelog

  • English Changelog: 鈿★笍 Improve Table column.filterDropdown type.
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@codecov

This comment has been minimized.

Copy link

commented May 7, 2019

Codecov Report

Merging #16446 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16446   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files         257      257           
  Lines        7068     7068           
  Branches     2000     2002    +2     
=======================================
  Hits         6762     6762           
  Misses        305      305           
  Partials        1        1
Impacted Files Coverage 螖
components/table/filterDropdown.tsx 94.95% <0%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b41f9d6...969c171. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented May 7, 2019

Deploy preview for ant-design ready!

Built with commit 969c171

https://deploy-preview-16446--ant-design.netlify.com

@afc163 afc163 force-pushed the fix-filterDropdown-ts branch from 360062e to 969c171 May 7, 2019

@afc163 afc163 merged commit 927f99e into master May 7, 2019

26 of 30 checks passed

codecov/patch 0% of diff hit (target 95.67%)
Details
codebeat 8 issues resolved and 21 introduced
Details
Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/project 95.67% remains the same compared to b41f9d6
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-filterDropdown-ts branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.