Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ๐Ÿ› Fix Select selected and disabled item wrong hover color #16477

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented May 8, 2019

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ‘ป What's the background?

https://codesandbox.io/s/mm450opl09

image

๐Ÿ’ก Solution

image

๐Ÿ“ Changelog

  • English Changelog: ๐Ÿ› Fix Select selected and disabled item wrong hover color.
  • Chinese Changelog (optional): ๐Ÿ› ไฟฎๅค Select ๅฝ“ๅ‰้€‰ไธญ็š„ๅคฑๆ•ˆ้กน็š„ๆ ทๅผ้—ฎ้ข˜ใ€‚

โ˜‘๏ธ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/demo/basic.md

@afc163 afc163 force-pushed the fix-disable-option-style branch from 71f695a to a4fb429 May 8, 2019

@codecov

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #16477 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16477      +/-   ##
==========================================
- Coverage   95.69%   95.65%   -0.05%     
==========================================
  Files         258      258              
  Lines        7107     7107              
  Branches     1992     2002      +10     
==========================================
- Hits         6801     6798       -3     
- Misses        304      307       +3     
  Partials        2        2
Impacted Files Coverage ฮ”
components/_util/wave.tsx 85.84% <0%> (-2.84%) โฌ‡๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 6464cfd...a4fb429. Read the comment docs.

@ztplz

ztplz approved these changes May 8, 2019

@netlify

This comment has been minimized.

Copy link

commented May 8, 2019

Deploy preview for ant-design ready!

Built with commit 71f695a

https://deploy-preview-16477--ant-design.netlify.com

1 similar comment
@netlify

This comment has been minimized.

Copy link

commented May 8, 2019

Deploy preview for ant-design ready!

Built with commit 71f695a

https://deploy-preview-16477--ant-design.netlify.com

@netlify

This comment has been minimized.

Copy link

commented May 8, 2019

Deploy preview for ant-design ready!

Built with commit a4fb429

https://deploy-preview-16477--ant-design.netlify.com

@afc163 afc163 merged commit 4f74471 into master May 8, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No code changes detected
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6464cfd...a4fb429
Details
codecov/project 95.65% (-0.05%) compared to 6464cfd
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-disable-option-style branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You canโ€™t perform that action at this time.