Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ๐Ÿ› Fix Select selected and disabled item wrong hover color #16477

Merged
merged 1 commit into from May 8, 2019

Conversation

@afc163
Copy link
Member

@afc163 afc163 commented May 8, 2019

๐Ÿค” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

๐Ÿ‘ป What's the background?

https://codesandbox.io/s/mm450opl09

image

๐Ÿ’ก Solution

image

๐Ÿ“ Changelog

  • English Changelog: ๐Ÿ› Fix Select selected and disabled item wrong hover color.
  • Chinese Changelog (optional): ๐Ÿ› ไฟฎๅค Select ๅฝ“ๅ‰้€‰ไธญ็š„ๅคฑๆ•ˆ้กน็š„ๆ ทๅผ้—ฎ้ข˜ใ€‚

โ˜‘๏ธ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/demo/basic.md

@afc163 afc163 force-pushed the fix-disable-option-style branch from 71f695a to a4fb429 May 8, 2019
@codecov
Copy link

@codecov codecov bot commented May 8, 2019

Codecov Report

Merging #16477 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16477      +/-   ##
==========================================
- Coverage   95.69%   95.65%   -0.05%     
==========================================
  Files         258      258              
  Lines        7107     7107              
  Branches     1992     2002      +10     
==========================================
- Hits         6801     6798       -3     
- Misses        304      307       +3     
  Partials        2        2
Impacted Files Coverage ฮ”
components/_util/wave.tsx 85.84% <0%> (-2.84%) โฌ‡๏ธ

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 6464cfd...a4fb429. Read the comment docs.

ztplz
ztplz approved these changes May 8, 2019
@netlify
Copy link

@netlify netlify bot commented May 8, 2019

Deploy preview for ant-design ready!

Built with commit 71f695aa48f0370530680c749c35539eba9c5e6a

https://deploy-preview-16477--ant-design.netlify.com

1 similar comment
@netlify
Copy link

@netlify netlify bot commented May 8, 2019

Deploy preview for ant-design ready!

Built with commit 71f695aa48f0370530680c749c35539eba9c5e6a

https://deploy-preview-16477--ant-design.netlify.com

@netlify
Copy link

@netlify netlify bot commented May 8, 2019

Deploy preview for ant-design ready!

Built with commit a4fb429

https://deploy-preview-16477--ant-design.netlify.com

@afc163 afc163 merged commit 4f74471 into master May 8, 2019
30 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-disable-option-style branch May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants