Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing `style` ts def in List #16485

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
1 participant
@zombieJ
Copy link
Member

commented May 8, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #16479

馃挕 Solution

Add missing def

馃摑 Changelog

Fix List missing style prop definition.

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented May 8, 2019

Deploy preview for ant-design ready!

Built with commit 37ea538

https://deploy-preview-16485--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 8, 2019

Codecov Report

Merging #16485 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16485   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files         258      258           
  Lines        7107     7107           
  Branches     2002     2002           
=======================================
  Hits         6798     6798           
  Misses        307      307           
  Partials        2        2
Impacted Files Coverage 螖
components/list/index.tsx 97.77% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2d8396b...37ea538. Read the comment docs.

@zombieJ zombieJ merged commit 961328b into master May 8, 2019

27 of 30 checks passed

License Compliance FOSSA is analyzing this commit
Details
Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
CodeFactor 1 issue fixed. 1 issue found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 2d8396b...37ea538
Details
codecov/project 95.65% remains the same compared to 2d8396b
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the list-ts branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.