Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pagination support `disabled` prop #16493

Merged
merged 6 commits into from May 10, 2019

Conversation

Projects
None yet
2 participants
@zombieJ
Copy link
Member

commented May 9, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15986

馃挕 Solution

Update rc-pagination

馃摑 Changelog

Pagination support disabled prop

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/pagination/index.en-US.md
View rendered components/pagination/index.zh-CN.md

zombieJ added some commits May 9, 2019

@netlify

This comment has been minimized.

Copy link

commented May 9, 2019

Deploy preview for ant-design ready!

Built with commit 16431c5

https://deploy-preview-16493--ant-design.netlify.com

@buildsize

This comment has been minimized.

Copy link

commented May 9, 2019

File name Previous Size New Size Change
package-lock.json 819.41聽KB 820.57聽KB 1.15聽KB (0%)
@netlify

This comment has been minimized.

Copy link

commented May 9, 2019

Deploy preview for ant-design ready!

Built with commit fda7f0a

https://deploy-preview-16493--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #16493 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #16493   +/-   ##
========================================
  Coverage    95.65%   95.65%           
========================================
  Files          258      258           
  Lines         7107     7107           
  Branches      2004     1968   -36     
========================================
  Hits          6798     6798           
  Misses         307      307           
  Partials         2        2
Impacted Files Coverage 螖
components/pagination/Pagination.tsx 100% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 108caa2...fda7f0a. Read the comment docs.

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

绠ご disabled 鐨勬牱寮忔湁鐐归棶棰樸

鍐呴儴鎸夐挳鐨 disabled className 涔熷彨 ant-pagination-disabled锛岄儊闂封︹

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented May 9, 2019

Update. Please check again.

Disabled shapshot:
灞忓箷蹇収 2019-05-09 涓嬪崍4 11 49

@afc163

This comment has been minimized.

Copy link
Member

commented May 9, 2019

鏉ヤ釜 disabled 鐨勪緥瀛愬惂銆

@afc163

This comment has been minimized.

Copy link
Member

commented May 9, 2019

鍥剧墖

杩欐牱濂戒簡锛屾垨鑰呮壘涓嬭璁″笀銆

  • 鏁板瓧鑹诧細rgba(0, 0, 0, .25)
  • 鑳屾櫙鑹诧細#f5f5f5
  • 褰撳墠鑳屾櫙鑹诧細#d9d9d9
@zombieJ

This comment has been minimized.

@afc163

This comment has been minimized.

Copy link
Member

commented May 10, 2019

瀛楄壊鏀规垚锛color: rgba(0,0,0, .25); 鍚с

@afc163

afc163 approved these changes May 10, 2019

@zombieJ zombieJ merged commit e88589d into feature May 10, 2019

25 of 28 checks passed

License Compliance FOSSA is analyzing this commit
Details
Header rules No header rules processed
Details
Pages changed 213 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json up by 1.15聽KB (0.14%)
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 108caa2...fda7f0a
Details
codecov/project 95.65% remains the same compared to 108caa2
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the pagination-disabled branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.