Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[Select]: add missing type definition #16504

Merged

Conversation

@SylvanasGone
Copy link
Contributor

@SylvanasGone SylvanasGone commented May 9, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

As mentioned in the document of React-component/Select, Select should have the property 'maxTagTextLength', but I got a type warning when using it in Antd.

馃挕 Solution

Add missing typescript definition.

馃摑 Changelog

  • English Changelog:
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/select/index.en-US.md
View rendered components/select/index.zh-CN.md

@zombieJ
Copy link
Member

@zombieJ zombieJ commented May 9, 2019

md file table format should not change.

@netlify
Copy link

@netlify netlify bot commented May 9, 2019

Deploy preview for ant-design ready!

Built with commit 50627e1

https://deploy-preview-16504--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented May 9, 2019

Codecov Report

Merging #16504 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16504   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         258      258           
  Lines        7117     7117           
  Branches     1968     2002   +34     
=======================================
  Hits         6812     6812           
  Misses        303      303           
  Partials        2        2
Impacted Files Coverage 螖
components/select/index.tsx 96.87% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 62f8924...a9f49f7. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented May 9, 2019

Codecov Report

Merging #16504 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16504   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         258      258           
  Lines        7120     7120           
  Branches     1970     2004   +34     
=======================================
  Hits         6815     6815           
  Misses        303      303           
  Partials        2        2
Impacted Files Coverage 螖
components/select/index.tsx 96.87% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 2bfecc3...50627e1. Read the comment docs.

| defaultOpen | 鏄惁榛樿灞曞紑涓嬫媺鑿滃崟 | boolean | - |
| open | 鏄惁灞曞紑涓嬫媺鑿滃崟 | boolean | - |
| onDropdownVisibleChange | 灞曞紑涓嬫媺鑿滃崟鐨勫洖璋 (3.9.0 鍚庢敮鎸) | function(open) | - |
| loading | 鍔犺浇涓姸鎬 | Boolean | false |
Copy link
Member

@afc163 afc163 May 9, 2019

涓嶈淇敼 markdown 鏍煎紡銆

@SylvanasGone
Copy link
Contributor Author

@SylvanasGone SylvanasGone commented May 10, 2019

Prettier automatically format the md files in the pre-commit hook, actually.
If you run "yarn prettier", all the other md files would be reformatted.
The problem is current Prettier version 1.17(stable) would not format it correctly unless using master version.
https://prettier.io/blog/2019/04/12/1.17.0.html#markdown
@zombieJ @afc163

seems it should be another issue or PR

@zombieJ
Copy link
Member

@zombieJ zombieJ commented May 10, 2019

Hi @SylvanasGone, try to reinstall node_modules and retry. This https://prettier.io/blog/2019/04/12/1.17.0.html#markdown update is by @chenshuai2144 which used to process antd document format issue.
It should not change the md file style:

$ npm run prettier
Checking formatting...
.vscode/settings.json
components/calendar/locale/en_US.js
components/date-picker/locale/ar_EG.jsx
components/date-picker/locale/bg_BG.jsx
...

$ git st
## master...origin/master
(nothing changed)

@SylvanasGone SylvanasGone force-pushed the fix-select-type-max-tag-text-length branch from a9f49f7 to bf1b0eb May 10, 2019
@SylvanasGone
Copy link
Contributor Author

@SylvanasGone SylvanasGone commented May 10, 2019

@zombieJ Thanks, done.

@zombieJ zombieJ merged commit 6eacfd7 into ant-design:master May 10, 2019
28 of 29 checks passed
@SylvanasGone SylvanasGone deleted the fix-select-type-max-tag-text-length branch May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants