Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PageHeader): Should not render blank dom #16510

Merged
merged 2 commits into from May 9, 2019

Conversation

Projects
None yet
2 participants
@yociduo
Copy link
Contributor

commented May 9, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

Close #16501 .

馃挕 Solution

馃摑 Changelog

  • English Changelog:
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify

This comment has been minimized.

Copy link

commented May 9, 2019

Deploy preview for ant-design ready!

Built with commit cb30df5

https://deploy-preview-16510--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 9, 2019

Codecov Report

Merging #16510 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16510      +/-   ##
==========================================
- Coverage   95.75%   95.71%   -0.05%     
==========================================
  Files         258      258              
  Lines        7117     7120       +3     
  Branches     2002     1994       -8     
==========================================
  Hits         6815     6815              
- Misses        300      303       +3     
  Partials        2        2
Impacted Files Coverage 螖
components/page-header/index.tsx 100% <100%> (酶) 猬嗭笍
components/_util/wave.tsx 85.84% <0%> (-2.84%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 681c6a5...90ee259. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented May 9, 2019

Deploy preview for ant-design ready!

Built with commit 90ee259

https://deploy-preview-16510--ant-design.netlify.com

@afc163 afc163 merged commit db8c54e into ant-design:master May 9, 2019

27 of 29 checks passed

Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.75%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +4.24% compared to 681c6a5
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.