Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): improve field error method type defs #16524

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
2 participants
@vicrep
Copy link
Contributor

commented May 10, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

getFieldError and getFieldsError's return types are too restrictive, forcing consumers to cast the methods when using them.

馃挕 Solution

Change getFieldError and getFieldsError to return actual types, instead of very restrictive Object type (which should be avoided in general, in favour of unknown, object, or Record depending on actual use).

馃摑 Changelog

  • English Changelog: improve return type of form field error getters
  • Chinese Changelog (optional): ?

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
fix(forms): improve field error method type defs
Change `getFieldError` and `getFieldsError` to return actual types, instead of very restrictive `Object` type (which should be avoided in general, in favour of `unknown`, `object`, or `Record` depending on actual use).
@netlify

This comment has been minimized.

Copy link

commented May 10, 2019

Deploy preview for ant-design ready!

Built with commit 6119095

https://deploy-preview-16524--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #16524 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16524   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         258      258           
  Lines        7120     7120           
  Branches     1970     1970           
=======================================
  Hits         6815     6815           
  Misses        303      303           
  Partials        2        2
Impacted Files Coverage 螖
components/form/Form.tsx 91.3% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6eacfd7...6119095. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #16524 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16524   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         258      258           
  Lines        7120     7120           
  Branches     1970     1970           
=======================================
  Hits         6815     6815           
  Misses        303      303           
  Partials        2        2
Impacted Files Coverage 螖
components/form/Form.tsx 91.3% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6eacfd7...6119095. Read the comment docs.

@afc163 afc163 merged commit b3e90d7 into ant-design:master May 11, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 212 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6eacfd7...6119095
Details
codecov/project 95.71% remains the same compared to 6eacfd7
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.