Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload prop onRemove: allow Promise as return type #16570

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
2 participants
@christophehurpeau
Copy link
Contributor

commented May 13, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

Promise is supported in onRemove but not allowed in typescript typings

https://github.com/ant-design/ant-design/blob/master/components/upload/Upload.tsx#L170

馃挕 Solution

Add the missing return type

馃摑 Changelog

  • English Changelog: Allow Promise as typescript return type of prop onRemove in Upload component
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label May 13, 2019

@netlify

This comment has been minimized.

Copy link

commented May 13, 2019

Deploy preview for ant-design ready!

Built with commit 2d986ba

https://deploy-preview-16570--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #16570 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16570      +/-   ##
==========================================
+ Coverage   95.71%   95.75%   +0.04%     
==========================================
  Files         258      258              
  Lines        7120     7120              
  Branches     1970     1970              
==========================================
+ Hits         6815     6818       +3     
+ Misses        303      300       -3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 88.67% <0%> (+2.83%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6379999...2d986ba. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented May 13, 2019

Codecov Report

Merging #16570 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16570      +/-   ##
==========================================
+ Coverage   95.71%   95.75%   +0.04%     
==========================================
  Files         258      258              
  Lines        7120     7120              
  Branches     1970     1970              
==========================================
+ Hits         6815     6818       +3     
+ Misses        303      300       -3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 88.67% <0%> (+2.83%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6379999...2d986ba. Read the comment docs.

@christophehurpeau christophehurpeau referenced this pull request May 21, 2019

Merged

fix: Upload prop action: fix typings #16716

5 of 14 tasks complete

@afc163 afc163 changed the title Upload prop onRemove: allow Promise as return type chore: Upload prop onRemove: allow Promise as return type May 21, 2019

@afc163 afc163 changed the title chore: Upload prop onRemove: allow Promise as return type fix: Upload prop onRemove: allow Promise as return type May 21, 2019

@afc163 afc163 merged commit 263a3e7 into ant-design:master May 21, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6379999...2d986ba
Details
codecov/project 95.75% (+0.04%) compared to 6379999
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels May 21, 2019

@christophehurpeau christophehurpeau deleted the christophehurpeau:patch-1 branch May 22, 2019

@zombieJ zombieJ referenced this pull request May 26, 2019

Merged

docs: 3.19.0 changelog #16796

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.