Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Form): improve onFieldsChange params type defs #16577

Merged
merged 1 commit into from May 15, 2019

Conversation

@SylvanasGone
Copy link
Contributor

@SylvanasGone SylvanasGone commented May 14, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

onFieldsChange's second param changeFields type is so restrictive that users have to cast the actual def when using it in Typescript.

馃挕 Solution

Replace type definition object with any.

馃摑 Changelog

  • English Changelog: Improve onFieldsChange params type of Form.create() method in Form.
  • Chinese Changelog (optional):

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@netlify
Copy link

@netlify netlify bot commented May 14, 2019

Deploy preview for ant-design ready!

Built with commit 8c8ca49

https://deploy-preview-16577--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented May 14, 2019

Codecov Report

Merging #16577 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16577   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         258      258           
  Lines        7120     7120           
  Branches     1970     2004   +34     
=======================================
  Hits         6815     6815           
  Misses        303      303           
  Partials        2        2
Impacted Files Coverage 螖
components/form/Form.tsx 91.3% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6379999...8c8ca49. Read the comment docs.

1 similar comment
@codecov
Copy link

@codecov codecov bot commented May 14, 2019

Codecov Report

Merging #16577 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16577   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         258      258           
  Lines        7120     7120           
  Branches     1970     2004   +34     
=======================================
  Hits         6815     6815           
  Misses        303      303           
  Partials        2        2
Impacted Files Coverage 螖
components/form/Form.tsx 91.3% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6379999...8c8ca49. Read the comment docs.

@zombieJ zombieJ merged commit a19a500 into ant-design:master May 15, 2019
29 checks passed
@SylvanasGone SylvanasGone deleted the fix-form-ts branch May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants