Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect tree type #16624

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
2 participants
@ztplz
Copy link
Collaborator

commented May 16, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

馃挕 Solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label May 16, 2019

@ztplz ztplz requested review from zombieJ and afc163 May 16, 2019

@ztplz

This comment has been minimized.

Copy link
Collaborator Author

commented May 16, 2019

@eruca 鎴戣寰椾綘璇寸殑鍙兘鏄繖涓

@netlify

This comment has been minimized.

Copy link

commented May 16, 2019

Deploy preview for ant-design ready!

Built with commit a067efb

https://deploy-preview-16624--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #16624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16624   +/-   ##
=======================================
  Coverage    95.7%    95.7%           
=======================================
  Files         258      258           
  Lines        7127     7127           
  Branches     2007     1997   -10     
=======================================
  Hits         6821     6821           
  Misses        304      304           
  Partials        2        2
Impacted Files Coverage 螖
components/tree/Tree.tsx 96.87% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e0fae5d...a067efb. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #16624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16624   +/-   ##
=======================================
  Coverage    95.7%    95.7%           
=======================================
  Files         258      258           
  Lines        7127     7127           
  Branches     2007     1997   -10     
=======================================
  Hits         6821     6821           
  Misses        304      304           
  Partials        2        2
Impacted Files Coverage 螖
components/tree/Tree.tsx 96.87% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e0fae5d...a067efb. Read the comment docs.

@zombieJ zombieJ merged commit 9308f19 into ant-design:master May 16, 2019

26 of 29 checks passed

Semantic Pull Request add a semantic commit or PR title
Details
Header rules No header rules processed
Details
Pages changed 214 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e0fae5d...a067efb
Details
codecov/project 95.7% remains the same compared to e0fae5d
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels May 16, 2019

@ztplz

This comment has been minimized.

Copy link
Collaborator Author

commented May 16, 2019

Relate to锛 #16618

@ztplz ztplz deleted the ztplz:tree branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.