Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tree.onDragEnter function parameter #16638

Merged
merged 1 commit into from May 17, 2019

Conversation

Projects
None yet
3 participants
@eruca
Copy link
Contributor

commented May 16, 2019

官方的示例里有expandedKeys, 可是typescript定义里没有,所以扩展一下

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English add new interface AntTreeNodeDragEnterEvent onDragEnter
🇨🇳 Chinese 增加一个新的接口AntTreeNodeDragEnterEvent作为onDragEnter函数参数

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
onDragEnter的函数定义缺少一个expandedKeys:string[]?
官方的示例里有expandedKeys, 可是typescript定义里没有,所以扩展一下

@pr-triage pr-triage bot added the PR: unreviewed label May 16, 2019

@netlify

This comment has been minimized.

Copy link

commented May 16, 2019

Deploy preview for ant-design ready!

Built with commit 7cb4a11

https://deploy-preview-16638--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #16638 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16638      +/-   ##
==========================================
+ Coverage    95.7%   95.74%   +0.04%     
==========================================
  Files         258      258              
  Lines        7127     7127              
  Branches     1973     1973              
==========================================
+ Hits         6821     6824       +3     
+ Misses        304      301       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/tree/Tree.tsx 96.87% <ø> (ø) ⬆️
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9308f19...7cb4a11. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented May 16, 2019

Codecov Report

Merging #16638 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16638      +/-   ##
==========================================
+ Coverage    95.7%   95.74%   +0.04%     
==========================================
  Files         258      258              
  Lines        7127     7127              
  Branches     1973     1973              
==========================================
+ Hits         6821     6824       +3     
+ Misses        304      301       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/tree/Tree.tsx 96.87% <ø> (ø) ⬆️
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9308f19...7cb4a11. Read the comment docs.

@ztplz

ztplz approved these changes May 16, 2019

@afc163 afc163 merged commit 0c1b062 into ant-design:master May 17, 2019

27 of 29 checks passed

Header rules No header rules processed
Details
Pages changed 220 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 9308f19...7cb4a11
Details
codecov/project 95.74% (+0.04%) compared to 9308f19
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.