Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix horizontal divider style #16684

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
2 participants
@ycjcl868
Copy link
Member

commented May 20, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

https://codesandbox.io/s/hardcore-wescoff-x4br5

image

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English 🐞 Fix PageHeader horizontal divider style. #16684
🇨🇳 Chinese 🐞 修复 PageHeader 中水平分割线样式问题。#16684

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label May 20, 2019

@netlify

This comment has been minimized.

Copy link

commented May 20, 2019

Deploy preview for ant-design ready!

Built with commit 4a05444

https://deploy-preview-16684--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #16684 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16684   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         258      258           
  Lines        7140     7140           
  Branches     2008     2008           
=======================================
  Hits         6837     6837           
  Misses        301      301           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc232a...4a05444. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

commented May 21, 2019

changelog?

@ycjcl868

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

done.

@afc163 afc163 merged commit a1e593b into master May 21, 2019

26 of 30 checks passed

Semantic Pull Request add a semantic commit or PR title
Details
Header rules No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed 212 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 2cc232a...4a05444
Details
codecov/project 95.75% remains the same compared to 2cc232a
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels May 21, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-divider-style branch May 21, 2019

@zombieJ zombieJ referenced this pull request May 26, 2019

Merged

docs: 3.19.0 changelog #16796

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.