Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pressing ESC to close drawer #16694

Merged
merged 6 commits into from May 22, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented May 21, 2019

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

πŸ‘» What's the background?

close #11628

πŸ’‘ Solution

Upgrade to rc-drawer@1.9.0: react-component/drawer#94

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English support pressing ESC to close drawer. #11628
πŸ‡¨πŸ‡³ Chinese Drawer ζ”―ζŒ ESC 关闭。 #11628

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label May 21, 2019

@netlify

This comment has been minimized.

Copy link

commented May 21, 2019

Deploy preview for ant-design ready!

Built with commit 9f21fe8

https://deploy-preview-16694--ant-design.netlify.com

@netlify

This comment has been minimized.

Copy link

commented May 21, 2019

Deploy preview for ant-design ready!

Built with commit 9d12c82

https://deploy-preview-16694--ant-design.netlify.com

@afc163 afc163 changed the title feature: support pressing ESC to close drawer [WIP] feature: support pressing ESC to close drawer May 21, 2019

@pr-triage pr-triage bot removed the PR: unreviewed label May 21, 2019

@afc163 afc163 referenced this pull request May 21, 2019

Merged

add key esc #94

@jljsj33 jljsj33 self-requested a review May 21, 2019

@jljsj33

This comment has been minimized.

Copy link
Member

commented May 21, 2019

config-provider θΏ™ι‡Œζ€ŽδΉˆζœ‰ι‡ε€ηš„η”¨δΎ‹εœ¨ζ΅‹οΌŸ

@afc163

This comment has been minimized.

Copy link
Member Author

commented May 21, 2019

@codecov

This comment has been minimized.

Copy link

commented May 21, 2019

Codecov Report

Merging #16694 into feature will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #16694   +/-   ##
========================================
  Coverage    95.74%   95.74%           
========================================
  Files          259      259           
  Lines         7198     7198           
  Branches      1984     2020   +36     
========================================
  Hits          6892     6892           
  Misses         304      304           
  Partials         2        2
Impacted Files Coverage Ξ”
components/drawer/index.tsx 98.73% <100%> (ΓΈ) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 7a728da...9d12c82. Read the comment docs.

@jljsj33 jljsj33 changed the title [WIP] feature: support pressing ESC to close drawer feature: support pressing ESC to close drawer May 21, 2019

@jljsj33 jljsj33 changed the title feature: support pressing ESC to close drawer feat: support pressing ESC to close drawer May 21, 2019

@afc163 afc163 merged commit 633fd71 into feature May 22, 2019

26 of 28 checks passed

Header rules No header rules processed
Details
Pages changed 214 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.74%)
Details
codecov/project 95.74% (+0%) compared to 7a728da
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the upgrade-drawer branch May 22, 2019

@hsuanxyz hsuanxyz referenced this pull request May 24, 2019

Merged

feat(module:drawer): support pressing ESC to close drawer #3488

2 of 3 tasks complete

@zombieJ zombieJ referenced this pull request May 26, 2019

Merged

docs: 3.19.0 changelog #16796

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.