Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix Cascader displayRender not interactive #16782

Merged
merged 1 commit into from May 24, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented May 24, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #16738 and #10433

this bug had been fixed in bc4143f before, but it was broken by #12407

💡 Solution

Here we change another method to fix #12395

📝 Changelog

Language Changelog
🇺🇸 English Fix Cascader displayRender not interactive. #16738
🇨🇳 Chinese 修复 Cascader 自定义渲染时元素无法交互的问题。#16738

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
🐛 Fix Cascader displayRender not interactive
close #16738 and #10433

this bug had been fixed in bc4143f before, but it was broken by #12407

here we change another method to fix #12395

@pr-triage pr-triage bot added the PR: unreviewed label May 24, 2019

@netlify

This comment has been minimized.

Copy link

commented May 24, 2019

Deploy preview for ant-design ready!

Built with commit c102ef7

https://deploy-preview-16782--ant-design.netlify.com

@afc163 afc163 merged commit 06c03c8 into master May 24, 2019

16 of 28 checks passed

ant-design.ant-design in progress
Details
ci/circleci: test_dist Your tests are queued behind your running builds
Details
ci/circleci: test_dist_15 Your tests are queued behind your running builds
Details
ci/circleci: test_dom CircleCI is running your tests
Details
ci/circleci: test_dom_15 CircleCI is running your tests
Details
ci/circleci: test_es Your tests are queued behind your running builds
Details
ci/circleci: test_es_15 Your tests are queued behind your running builds
Details
ci/circleci: test_lib Your tests are queued behind your running builds
Details
ci/circleci: test_lib_15 Your tests are queued behind your running builds
Details
Header rules No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed 211 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-cascader-custom-item branch May 24, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels May 24, 2019

@zombieJ zombieJ referenced this pull request May 26, 2019

Merged

docs: 3.19.0 changelog #16796

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.