Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input parser type #16797

Merged
merged 1 commit into from May 26, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented May 26, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #15226

馃挕 Solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Correct InputNumber parser type. #15226
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label May 26, 2019

@netlify

This comment has been minimized.

Copy link

commented May 26, 2019

Deploy preview for ant-design ready!

Built with commit 35e2359

https://deploy-preview-16797--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 26, 2019

Codecov Report

Merging #16797 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16797      +/-   ##
==========================================
- Coverage   95.78%   95.75%   -0.03%     
==========================================
  Files         263      258       -5     
  Lines        7299     7141     -158     
  Branches     2000     2010      +10     
==========================================
- Hits         6991     6838     -153     
+ Misses        306      301       -5     
  Partials        2        2
Impacted Files Coverage 螖
components/input-number/index.tsx 100% <酶> (酶) 猬嗭笍
components/grid/row.tsx 94.23% <0%> (-5.77%) 猬囷笍
components/config-provider/renderEmpty.tsx 86.66% <0%> (-0.84%) 猬囷笍
components/mention/index.tsx 91.66% <0%> (-0.18%) 猬囷笍
components/breadcrumb/Breadcrumb.tsx 96.07% <0%> (酶) 猬嗭笍
components/drawer/index.tsx 98.73% <0%> (酶) 猬嗭笍
components/progress/progress.tsx 93.18% <0%> (酶) 猬嗭笍
components/modal/Modal.tsx 100% <0%> (酶) 猬嗭笍
components/date-picker/locale/lv_LV.tsx
components/time-picker/locale/lv_LV.tsx
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6af96e7...35e2359. Read the comment docs.

@afc163 afc163 merged commit 60ee01f into master May 26, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 908.13聽KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6af96e7...35e2359
Details
codecov/project 95.75% (-0.03%) compared to 6af96e7
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels May 26, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-input-number-parser-type branch May 26, 2019

@afc163 afc163 referenced this pull request May 26, 2019

Merged

docs: 3.19.0 changelog #16796

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.