Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

给上传组件添加disabled状态的cursor样式 #16799

Merged
merged 1 commit into from May 26, 2019

Conversation

Projects
None yet
2 participants
@attacking
Copy link

commented May 26, 2019

🤔 这个变动的性质是?

  • 新特性提交
  • [] 日常 bug 修复
  • 站点、文档改进
  • 组件样式改进
  • TypeScript 定义更新
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

👻 需求背景

目前的Upload组件在disabled状态下自身没有鼠标的not-allowed样式。

💡 解决方案和最终实现是?

给处于disabled状态下的Upload组件的.ant-upload-disabled节点添加cursor: not-allowed;

📝 更新日志怎么写?

☑️ 请求合并前的自查清单

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@pr-triage pr-triage bot added the PR: unreviewed label May 26, 2019

@netlify

This comment has been minimized.

Copy link

commented May 26, 2019

Deploy preview for ant-design ready!

Built with commit 1eb46eb

https://deploy-preview-16799--ant-design.netlify.com

@afc163 afc163 merged commit fecff0d into ant-design:master May 26, 2019

10 of 20 checks passed

ci/circleci: compile Your tests are queued behind your running builds
Details
ci/circleci: dist Your tests are queued behind your running builds
Details
ci/circleci: lint Your tests are queued behind your running builds
Details
ci/circleci: test_dom Your tests are queued behind your running builds
Details
ci/circleci: test_dom_15 Your tests are queued behind your running builds
Details
ci/circleci: test_node Your tests are queued behind your running builds
Details
ci/circleci: test_node_15 CircleCI is running your tests
Details
Header rules No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed 212 new files uploaded
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be merged or rebased
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@afc163 afc163 referenced this pull request May 26, 2019

Merged

docs: 3.19.0 changelog #16796

1 of 10 tasks complete

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels May 26, 2019

@codecov

This comment has been minimized.

Copy link

commented May 26, 2019

Codecov Report

Merging #16799 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16799      +/-   ##
==========================================
- Coverage   95.78%   95.71%   -0.07%     
==========================================
  Files         263      258       -5     
  Lines        7300     7141     -159     
  Branches     2000     1976      -24     
==========================================
- Hits         6992     6835     -157     
+ Misses        306      304       -2     
  Partials        2        2
Impacted Files Coverage Δ
components/grid/row.tsx 94.23% <0%> (-5.77%) ⬇️
components/config-provider/renderEmpty.tsx 86.66% <0%> (-0.84%) ⬇️
components/slider/index.tsx 88.57% <0%> (-0.32%) ⬇️
components/mention/index.tsx 91.66% <0%> (-0.18%) ⬇️
components/breadcrumb/Breadcrumb.tsx 96.07% <0%> (ø) ⬆️
components/drawer/index.tsx 98.73% <0%> (ø) ⬆️
components/progress/progress.tsx 93.18% <0%> (ø) ⬆️
components/modal/Modal.tsx 100% <0%> (ø) ⬆️
components/date-picker/locale/lv_LV.tsx
components/time-picker/locale/lv_LV.tsx
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ee01f...1eb46eb. Read the comment docs.

2 similar comments
@codecov

This comment has been minimized.

Copy link

commented May 26, 2019

Codecov Report

Merging #16799 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16799      +/-   ##
==========================================
- Coverage   95.78%   95.71%   -0.07%     
==========================================
  Files         263      258       -5     
  Lines        7300     7141     -159     
  Branches     2000     1976      -24     
==========================================
- Hits         6992     6835     -157     
+ Misses        306      304       -2     
  Partials        2        2
Impacted Files Coverage Δ
components/grid/row.tsx 94.23% <0%> (-5.77%) ⬇️
components/config-provider/renderEmpty.tsx 86.66% <0%> (-0.84%) ⬇️
components/slider/index.tsx 88.57% <0%> (-0.32%) ⬇️
components/mention/index.tsx 91.66% <0%> (-0.18%) ⬇️
components/breadcrumb/Breadcrumb.tsx 96.07% <0%> (ø) ⬆️
components/drawer/index.tsx 98.73% <0%> (ø) ⬆️
components/progress/progress.tsx 93.18% <0%> (ø) ⬆️
components/modal/Modal.tsx 100% <0%> (ø) ⬆️
components/date-picker/locale/lv_LV.tsx
components/time-picker/locale/lv_LV.tsx
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ee01f...1eb46eb. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented May 26, 2019

Codecov Report

Merging #16799 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16799      +/-   ##
==========================================
- Coverage   95.78%   95.71%   -0.07%     
==========================================
  Files         263      258       -5     
  Lines        7300     7141     -159     
  Branches     2000     1976      -24     
==========================================
- Hits         6992     6835     -157     
+ Misses        306      304       -2     
  Partials        2        2
Impacted Files Coverage Δ
components/grid/row.tsx 94.23% <0%> (-5.77%) ⬇️
components/config-provider/renderEmpty.tsx 86.66% <0%> (-0.84%) ⬇️
components/slider/index.tsx 88.57% <0%> (-0.32%) ⬇️
components/mention/index.tsx 91.66% <0%> (-0.18%) ⬇️
components/breadcrumb/Breadcrumb.tsx 96.07% <0%> (ø) ⬆️
components/drawer/index.tsx 98.73% <0%> (ø) ⬆️
components/progress/progress.tsx 93.18% <0%> (ø) ⬆️
components/modal/Modal.tsx 100% <0%> (ø) ⬆️
components/date-picker/locale/lv_LV.tsx
components/time-picker/locale/lv_LV.tsx
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ee01f...1eb46eb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.