Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix type of action and RcFile #16851

Merged
merged 2 commits into from Jun 2, 2019

Conversation

Projects
None yet
4 participants
@DiamondYuan
Copy link
Collaborator

commented May 29, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

馃挕 Solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label May 29, 2019

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented May 29, 2019

see #16850

@netlify

This comment has been minimized.

Copy link

commented May 29, 2019

Deploy preview for ant-design ready!

Built with commit 81da6e9

https://deploy-preview-16851--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented May 29, 2019

Codecov Report

Merging #16851 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16851      +/-   ##
==========================================
- Coverage      96%   95.96%   -0.05%     
==========================================
  Files         263      263              
  Lines        7329     7329              
  Branches     2035     2046      +11     
==========================================
- Hits         7036     7033       -3     
- Misses        291      294       +3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 85.84% <0%> (-2.84%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 81da6e9...c7bc6b7. Read the comment docs.

@DiamondYuan DiamondYuan requested a review from afc163 May 29, 2019

@DiamondYuan DiamondYuan changed the title fix: UploadFile should extends File [wip] fix: UploadFile should extends File May 29, 2019

@pr-triage pr-triage bot removed the PR: unreviewed label May 29, 2019

@DiamondYuan DiamondYuan changed the title [wip] fix: UploadFile should extends File fix: UploadFile should extends File May 29, 2019

@pr-triage pr-triage bot added the PR: unreviewed label May 29, 2019

@zombieJ

This comment has been minimized.

Copy link
Member

commented May 29, 2019

UploadFile 绫讳技 File 浣嗘槸涓嶆槸缁ф壙鍏崇郴锛岄氳繃 fileList or defaultFileList 璁剧疆鐨 file 涓嶄竴瀹氭槸鐪熺殑 File 瀵硅薄銆

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented May 29, 2019

UploadFile 绫讳技 File 浣嗘槸涓嶆槸缁ф壙鍏崇郴锛岄氳繃 fileList or defaultFileList 璁剧疆鐨 file 涓嶄竴瀹氭槸鐪熺殑 File 瀵硅薄銆

涔熷氨鏄鏈変袱绉嶇被鍨嬶紵涓绉嶆槸 extends file鐨勶紝鍦 action 绛夊湴鏂圭敤鍒般
涓绉嶆槸 UploadFile 锛屽湪 render file list鐨勬椂鍊欑敤鍒帮紵

@DiamondYuan

This comment has been minimized.

Copy link
Collaborator Author

commented May 29, 2019

鐪嬩簡涓涓 action 鎺ュ彈鐨勫弬鏁板ソ鍍忎笉鏄 UploadFile

@DiamondYuan DiamondYuan changed the title fix: UploadFile should extends File [wip] fix: UploadFile should extends File May 29, 2019

@pr-triage pr-triage bot removed the PR: unreviewed label May 29, 2019

@DiamondYuan DiamondYuan force-pushed the fix/uploadFile-type-again branch from dee548e to 81da6e9 May 29, 2019

@afc163 afc163 deleted the fix/uploadFile-type-again branch May 29, 2019

DiamondYuan added some commits May 29, 2019

@DiamondYuan DiamondYuan changed the title [wip] fix: UploadFile should extends File fix: UploadFile should extends File May 29, 2019

@pr-triage pr-triage bot added the PR: unreviewed label May 29, 2019

@DiamondYuan DiamondYuan requested a review from zombieJ May 29, 2019

@DiamondYuan DiamondYuan reopened this May 29, 2019

@DiamondYuan DiamondYuan changed the title fix: UploadFile should extends File fix: fix type of action and RcFile May 29, 2019

@afc163 afc163 merged commit 18d3dee into master Jun 2, 2019

25 checks passed

CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 81da6e9...c7bc6b7
Details
codecov/project 95.96% (-0.05%) compared to 81da6e9
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 2, 2019

readonly lastModified: number;
readonly lastModifiedDate: Date;
readonly size: number;
readonly webkitRelativePath: string;

This comment has been minimized.

Copy link
@ztplz

ztplz Jun 2, 2019

Collaborator

鍙湁webkitRelativePath 鏄渶瑕佸姞鐨 閲嶅瀹氫箟浜 鍍name, type, lastModified, size閮芥槸 File 閲屾湰韬氨鏈夌殑

@pr-triage pr-triage bot added PR: unreviewed and removed PR: merged labels Jun 2, 2019

@ikobe ikobe referenced this pull request Jun 6, 2019

Merged

docs: 3.19.3 change-log #16998

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.