Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use @error-color & @warning-color instead of @text-color-danger & @text-color-warning #16856 #16890

Merged
merged 1 commit into from May 30, 2019

Conversation

Projects
None yet
2 participants
@MrHeer
Copy link
Contributor

commented May 30, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #16856

💡 Solution

use @error-color & @warning-color instead of @text-color-danger & @text-color-warning

📝 Changelog

Language Changelog
🇺🇸 English use @error-color & @warning-color instead of @text-color-danger & @text-color-warning
🇨🇳 Chinese 用 @error-color & @warning-color 代替 @text-color-danger & @text-color-warning

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label May 30, 2019

@codecov

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #16890 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16890   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         263      263           
  Lines        7329     7329           
  Branches     2048     2046    -2     
=======================================
  Hits         7033     7033           
  Misses        294      294           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb8692...239c472. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #16890 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16890   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         263      263           
  Lines        7329     7329           
  Branches     2048     2046    -2     
=======================================
  Hits         7033     7033           
  Misses        294      294           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb8692...239c472. Read the comment docs.

@afc163 afc163 merged commit c6f991d into ant-design:master May 30, 2019

23 of 24 checks passed

LGTM analysis: JavaScript No code changes detected
Details
CodeFactor 1 issue fixed.
Details
DEP All dependencies are resolved
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing abb8692...239c472
Details
codecov/project 95.96% remains the same compared to abb8692
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels May 30, 2019

@MrHeer MrHeer deleted the MrHeer:fix-#16856 branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.