Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cascader unable to enter space during search #16871 #16918

Merged
merged 1 commit into from Jun 2, 2019

Conversation

Projects
None yet
2 participants
@Durisvk
Copy link
Contributor

commented Jun 1, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

Issue #16871

Hitting space in a Cascader component with showSearch prop filled in blurs from the input field - therefore the whitespace character is unable to be entered into the input field!

馃挕 Solution

Prevent default browser behavior while hitting space (the same applies for backspace which was already in the codebase).

馃摑 Changelog

No breaking changes - the API stays the same

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 1, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 1, 2019

Codecov Report

Merging #16918 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16918      +/-   ##
==========================================
- Coverage      96%   95.96%   -0.05%     
==========================================
  Files         263      263              
  Lines        7329     7329              
  Branches     2008     2008              
==========================================
- Hits         7036     7033       -3     
- Misses        291      294       +3     
  Partials        2        2
Impacted Files Coverage 螖
components/cascader/index.tsx 96.9% <100%> (酶) 猬嗭笍
components/_util/wave.tsx 85.84% <0%> (-2.84%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 86bc281...24ee163. Read the comment docs.

@Durisvk Durisvk changed the title :bug: fixes #16871 Cascader - Space during search Cascader - Space during search Jun 1, 2019

@Durisvk Durisvk changed the title Cascader - Space during search fix: cascader - space during search Jun 2, 2019

@Durisvk Durisvk changed the title fix: cascader - space during search fix: cascader unable to enter space during search #16871 Jun 2, 2019

@afc163 afc163 merged commit 7c0fd87 into ant-design:master Jun 2, 2019

24 checks passed

CodeFactor 1 issue fixed. 1 issue found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +3.99% compared to 86bc281
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 2, 2019

@ikobe ikobe referenced this pull request Jun 6, 2019

Merged

docs: 3.19.3 change-log #16998

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.