Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: abnormal scrollbar in Chrome #16934

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented Jun 3, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

when rowSelection and title work together

close #16912

💡 Solution

Remove overflow: hidden added in 4b2e9bb before, which seems to be OK now.

📝 Changelog

Language Changelog
🇺🇸 English Fix Table abnormal scrollbar in Chrome when using title and rowSelection.
🇨🇳 Chinese 修复 Table 当 title 和 rowSelection 同时指定时在 Chrome 下滚动条异常的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
🐛 Fix abnormal scrollbar in Chrome
when rowSelection and title work together

close #16912

@pr-triage pr-triage bot added the PR: unreviewed label Jun 3, 2019

@afc163 afc163 changed the title fix: abnormal scrollbar in Chrome [WIP] fix: abnormal scrollbar in Chrome Jun 3, 2019

@pr-triage pr-triage bot removed the PR: unreviewed label Jun 3, 2019

@afc163

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

wait for #16933

@codecov

This comment has been minimized.

Copy link

commented Jun 3, 2019

Codecov Report

Merging #16934 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16934      +/-   ##
==========================================
- Coverage      96%   95.96%   -0.05%     
==========================================
  Files         263      263              
  Lines        7327     7327              
  Branches     2046     2006      -40     
==========================================
- Hits         7034     7031       -3     
- Misses        291      294       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d2a5df...eb063d5. Read the comment docs.

@afc163 afc163 changed the title [WIP] fix: abnormal scrollbar in Chrome fix: abnormal scrollbar in Chrome Jun 5, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Jun 5, 2019

@afc163 afc163 merged commit c6e56e6 into master Jun 5, 2019

24 of 27 checks passed

LGTM analysis: JavaScript No code changes detected
Details
packtracker/css 484 KB — ▼ 0.00%
Details
packtracker/javascript 3.74 MB — No Change
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 823.25 KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6d2a5df...eb063d5
Details
codecov/project 95.96% (-0.05%) compared to 6d2a5df
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 5, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-table-scroll-bar branch Jun 5, 2019

@ikobe ikobe referenced this pull request Jun 6, 2019

Merged

docs: 3.19.3 change-log #16998

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.