Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added three variables to allow customization of the dropdown list #16996

Merged

Conversation

Projects
None yet
2 participants
@alxkosov
Copy link
Contributor

commented Jun 6, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

  1. There was a problem with customizing the drop-down menu.

  2. It was impossible to customize the appearance of the drop-down menu using variables. Added three variables to allow customization of the drop-down list

馃挕 Solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 6, 2019

@alxkosov alxkosov force-pushed the alxkosov:add_vars_to_customization_dropdown branch from f2893ac to b075b9e Jun 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #16996 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #16996   +/-   ##
========================================
  Coverage    95.96%   95.96%           
========================================
  Files          263      263           
  Lines         7332     7332           
  Branches      2049     2009   -40     
========================================
  Hits          7036     7036           
  Misses         294      294           
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c8a9ca6...b075b9e. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #16996 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #16996   +/-   ##
========================================
  Coverage    95.96%   95.96%           
========================================
  Files          263      263           
  Lines         7332     7332           
  Branches      2049     2009   -40     
========================================
  Hits          7036     7036           
  Misses         294      294           
  Partials         2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c8a9ca6...b075b9e. Read the comment docs.

@afc163

afc163 approved these changes Jun 8, 2019

@afc163

afc163 approved these changes Jun 8, 2019

@afc163 afc163 changed the title added three variables to allow customization of the dropdown list feat: added three variables to allow customization of the dropdown list Jun 8, 2019

@afc163 afc163 merged commit 5168a5d into ant-design:feature Jun 8, 2019

21 of 24 checks passed

packtracker/css Awaiting your base commit report...
Details
packtracker/javascript Awaiting your base commit report...
Details
LGTM analysis: JavaScript No code changes detected
Details
DEP All dependencies are resolved
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c8a9ca6...b075b9e
Details
codecov/project 95.96% remains the same compared to c8a9ca6
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: reviewed-approved labels Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.