Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove margin for collapse arrow #17009

Merged
merged 3 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@mtadams007
Copy link
Contributor

commented Jun 7, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

  1. Using overflow auto adds scrollbar on collapse component when there is a header below.

collapseScrollBar

  1. We want to have a collapse component where we can scroll if the content is bigger than the height. Adding height: 100% and overflow: auto to the Collapse component causes a scrollbar to appear because the arrow within the header has a margin attached.

馃挕 Solution

  1. Remove the added margin for the header arrow.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 7, 2019

@buildsize

This comment has been minimized.

Copy link

commented Jun 7, 2019

File name Previous Size New Size Change
package-lock.json 828.34聽KB 826.14聽KB -2.19聽KB (0%)
@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #17009 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17009   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         263      263           
  Lines        7336     7336           
  Branches     2047     2036   -11     
=======================================
  Hits         7040     7040           
  Misses        294      294           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 28d822e...0565faf. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #17009 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17009   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         263      263           
  Lines        7336     7336           
  Branches     2047     2036   -11     
=======================================
  Hits         7040     7040           
  Misses        294      294           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 28d822e...0565faf. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 7, 2019

Codecov Report

Merging #17009 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17009   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         263      263           
  Lines        7340     7340           
  Branches     2050     2048    -2     
=======================================
  Hits         7044     7044           
  Misses        294      294           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1a34dcd...4873dd0. Read the comment docs.

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Remove margin-top makes icon little up. Could you adjust this 2px also:
灞忓箷蹇収 2019-06-08 涓嬪崍10 13 01

@@ -39,7 +39,7 @@
display: inline-block;
font-size: @font-size-sm;
line-height: 46px;
transform: translateY(-50%);
transform: translateY(-21px);

This comment has been minimized.

Copy link
@mtadams007

mtadams007 Jun 10, 2019

Author Contributor

-50% would be -23px so by making it -21px we can eliminate the shift seen earlier

This comment has been minimized.

Copy link
@zombieJ

zombieJ Jun 11, 2019

Member

Maybe adjust line-height instead? Use px instead of % may little hard code.

@mtadams007

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

I put the transform back and removed line-height completely. It looked identical and had the arrow centered. I don't think that will affect anything else, but let me know if that's not acceptable.

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

CI broken, rebase please~

@mtadams007 mtadams007 force-pushed the mtadams007:bugfix/collapseArrow branch from a21bb80 to 513ff08 Jun 12, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 12, 2019

Deploy preview for ant-design ready!

Built with commit 4873dd0

https://deploy-preview-17009--ant-design.netlify.com

@mtadams007 mtadams007 force-pushed the mtadams007:bugfix/collapseArrow branch from 513ff08 to 4873dd0 Jun 12, 2019

@zombieJ zombieJ changed the title remove margin for collapse arrow fix: remove margin for collapse arrow Jun 13, 2019

@zombieJ zombieJ merged commit a85b449 into ant-design:master Jun 13, 2019

26 of 31 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 215 new files uploaded
Details
packtracker/css 480 KB 鈥 鈻 0.01%
Details
packtracker/javascript 1.83 MB 鈥 鈻 0.00%
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1a34dcd...4873dd0
Details
codecov/project 95.96% remains the same compared to 1a34dcd
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 13, 2019

Kiku-Reise added a commit to Kiku-Reise/ant-design that referenced this pull request Jun 14, 2019

fix (#3)
* Add fault-tolerant processing for rowSelection.getCheckboxProps

* Upload prop onRemove: allow Promise as return type

* onDragEnter鐨勫嚱鏁板畾涔夌己灏戜竴涓猠xpandedKeys:string[]?

瀹樻柟鐨勭ず渚嬮噷鏈塭xpandedKeys, 鍙槸typescript瀹氫箟閲屾病鏈夛紝鎵浠ユ墿灞曚竴涓

* Fix docs (ant-design#16637)

* Format (ant-design#16639)

* `==` to `===`

close ant-design#16640

* fix close  animation

* Update drawer.less

* fix space missing in button (ant-design#16551)

* feat: Add Mentions component (ant-design#16532)

* init

* first demo

* support empty

* add loading support

* add form sample

* update form sample

* omit value & defaultValue

* add 2 rest demo

* placement support

* update docs

* fix test

* update docs

* add test case

* fix lint

* follow textarea style

* update docs style

* 馃拕 unified Cascader selected style with Select

* docs: Add the changelog of 3.18.2 (ant-design#16666)

* Bump 3.18.2

* fix form typescript doc

* prettier md files

* Fix stylelint errors

* Add renovate.json

* Update renovate.json

* Refined translation of St.Exupery quote 

including link to quote site

* fix horizontal divider style

* 馃啓 support ESC to close drawer

*  update snapshots

* 馃拕 improve code style of Drawer

* update drawer version

* update config-provider test

* fix shouldComponentUpdate

* Upload prop onRemove: fix action

https://github.com/react-component/upload/tree/d0cf0eecee3b31888791f8c57acddb575bd259d4#api

* Update dependency logrocket to v1

* 馃拕 chore some documents style

* 馃摑 update customize theme

* 馃啓 rc-drawer 1.9.3

* 馃幀 Add example for Select ``optionLabelProp` prop, ant-design#16709

*  update snapshots

* 馃拕 fix emoji lint problem

https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/accessible-emoji.md

* New component Descriptions (ant-design#14645)

* add new component: DescriptionList

* add warning message

* docs: fix doc typo

* feat: implement the size attribute

* docs: fix doc typo

* refactor: use new name Descriptions

* test: snapshots updated

* feat: support react15

* style: fix code style warring

* style: better var name

* style: better code style

* style: merge css class

* feat: add responsive config

* fix: fix error title

* style: use @border-radius-base

* update snapshot

* feat: set default column

* test: add test script

* style: fix property defaultProps is useless error

* style: more robust code

* style: fix codereview warning

* style: fix review warning

* use responsiveObserveserve

* fix review warning

* bug: add childrenArray copy,prevent changes to incoming parameters

* fix dom error

* fix typo

* fix test

* don't use this

* snapshot updated

* prettier md

* remove descriptions md text

* new rendering method

* doc :add dot

* style: add right border

* Update index.en-US.md

add missing prop `showTitle` in documentation of Pagination

* adjust Carousel children change goto Logic (ant-design#16756)

* 馃摑 Add Programmatic Usage of antd colors

* update preview demo

* 馃悰 Fix Cascader displayRender not interactive

close ant-design#16738 and ant-design#10433

this bug had been fixed in bc4143f before, but it was broken by ant-design#12407

here we change another method to fix ant-design#12395

* Create FUNDING.yml

* 馃摑 Add opencollective link

* upload disabled remove

* feat: Steps support clickable (ant-design#16773)

* support clickable

* update snapshot

* update desc

* Locale (feat ant-design#16752): Added Latvian localization (ant-design#16780)

* update getPopupContainer (ant-design#16778)

since select/index.d.ts requires getPopupContainer={triggerNode => HTMLElement} but parentNode actually is not HTMLElement.

* Remove ancient prop types (ant-design#16705)

* Remove ancient Modal.propTypes.align and Progress.propTypes.size

* Remove linkRender and nameRender from Breadcrumb

* 馃悰 Fix Input parser type

close ant-design#15226

* feat: New calendar apis, headerRender method (ant-design#16535)

* added new calendar api, renderHeader now we can customize calendar header

* fixed typo for tests

* error handling for renderHeader

* covering all cases with tests

* fixed tests and change console error to warning

* fixed feedbacks and code optimization

* cleanup callback function arguments

* removed unused changes

* fixed tests

* added extra classes

* fixed some comments

* tying to fix test for remote

* tying to fix test for remote in my local machin it works fine

* tying to fix test for remote in my local machin it works fine

* tying to fix test for remote in my local machin it works fine

* updated test snapshots

* fixed comment

* fixed linting

* fixed some texts

* added header for CN and added argument types

* removed extra row

* Allow users to define where tooltips should appear on slider marks (ant-design#16641)

* feat: add disable style to upload component

* Fix the problem that the Slider's Tooltip is in the incorrect position when use modal	 (ant-design#16717)

* Fix incorrect position of tooltip when use slider

* Remove useless comment

* Reduce code

* Update

*  getTooltipPopupContainer default to body

* Public Slider's ref

* Add docs

* Update docs

* 馃拕 Correct Statistic font color (ant-design#16801)

close ant-design#15514

* docs: 3.19.0 changelog (ant-design#16796)

* add changelog

* add ant-design#16535

* update

* add missing changelog

* add ant-design#16801 changelog

* adjust description

* more desc

* more info

* change logo

* fix: mentions ts definition update (ant-design#16814)

* fix mentions ts definition

* adjust logic of Mentions

* fix: Tooltip not hidden when menu is in control mode (ant-design#16812)

* fix: Select ts define (ant-design#16817)

* fix: Descriptions warning should work as expect (ant-design#16819)

* fix warning

* add MockDate

* Fix typescript compile error (ant-design#16816)

* 馃悰 Fix typo name icons, add warning and update docs (ant-design#16818)

close ant-design#13007
close ant-design#16810

deps: ant-design/ant-design-icons#63

* docs: 3.19.1 change-log (ant-design#16820)

* update changelog

* add missing one

*  Add test case for TransButton

* fix: Tabs card vertical support scroll (ant-design#16825)

* Update util.test.js

* fix(Transfer): set state on an unmounted component (ant-design#16822)

* chore: Add warning if use `inlineCollapsed` under Sider (ant-design#16826)

* typescript: adding forceSubmenuRender as MenuProps

* 馃拕 Optimize examples code style

* Update index.en-US.md

* 鈿★笍 export TypographyProps

close ant-design#15190

* add onChange prop type definition to Steps

* add onChange prop type definition to Steps (ant-design#16845)

* add semicolon

* fix: add webkitRelativePath (ant-design#16850)

* fix: fix type of RcFile

* fix: fix type of action in UploadProps

* Update xhr2 requirement from ^0.1.4 to ^0.2.0

Updates the requirements on [xhr2](https://github.com/pwnall/node-xhr2) to permit the latest version.
- [Release notes](https://github.com/pwnall/node-xhr2/releases)
- [Commits](pwnall/node-xhr2@v0.1.4...0.2.0)

* Remove okButtonDisabled/cancelButtonDisabled never used prop defs

- Also remove them from the CHANGELOG because they were never actually
implemented, the prop was renamed to okButtonProps/cancelButtonProps
within PR ant-design#10955 but these prop defs were left behind and ended up
incorrectly included in the CHANGELOG.

* 淇Breadcrumb.tsx 涓鐞唕oute.children 璺緞涓嶅

<Menu.Item key={child.breadcrumbName || child.path}>
                {itemRender(child, params, routes, [...paths, this.getPath(child.path, params)])}
</Menu.Item>
itemRender(...args) 涓矾寰勫簲璇ュ埌鎷兼帴褰撳墠child.path

* fix Breadcrumb.tsx

getPath() 鍙傛暟璧嬮粯璁ゅ

* fix: use @error-color & @warning-color instead of @text-color-danger & @text-color-warning ant-design#16856

* fix Breadcrumb.tsx

瀵逛簬瀛愯矾寰勬槸鍚︿负绌鸿繘琛屽垽鏂

* add antd pro 4.0 badge (ant-design#16894)

* Update ansi-styles requirement from ^3.2.1 to ^4.0.0

Updates the requirements on [ansi-styles](https://github.com/chalk/ansi-styles) to permit the latest version.
- [Release notes](https://github.com/chalk/ansi-styles/releases)
- [Commits](chalk/ansi-styles@v3.2.1...v4.0.0)

* doc: changelog 3.19.2

* doc: changelog

* tweak: order changelog

* doc: changelog

* doc: changelog

* doc: changelog

* doc: changelog

* doc: format

* doc: changelog

* 馃摑 changelog

* 馃摑 changelog

* release: 3.19.2

* 馃悰 fixes ant-design#16871 Cascader - Space during search

* 馃敡 Add packtracker

* Remove useless type

* fix: Transfer render Empty when customize without data (ant-design#16925)

* fix: Hide Spinner of InputNumber when type is number (ant-design#16926)

* fix: Hide Spinner of InputNumber when type is number

* Firefox not obedient

* fix: Breadcrumb validateDOMNesting warning (ant-design#16929)

* 馃悰 Fix Breadcrumb validateDOMNesting warning

```
Warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>.
    in a (created by Context.Consumer)
    in span (created by Context.Consumer)
    in a (created by Context.Consumer)
    in Trigger (created by Dropdown)
    in Dropdown (created by Context.Consumer)
    in Dropdown (created by Context.Consumer)
    in span (created by Context.Consumer)
    in BreadcrumbItem (created by Context.Consumer)
    in div (created by Context.Consumer)
    in Breadcrumb (created by TestBreadcrumb)
    in TestBreadcrumb
```

*  update snapshots

* Update Breadcrumb.tsx

* 馃悰 Fix abnormal scrollbar in Chrome

when rowSelection and title work together

close ant-design#16912

* 馃悰 Fix Table header extra scrollbar control

close ant-design#4637
close ant-design#14211

react-component/table#333

*  update snapshots

* 馃拕 Fix scrollbar border bottom

*  update snapshots

* 馃摑 fix size toc overflow style

* 馃拕 use marginRight remind developer

* fix: test ci

* rebase

* fix: Table miss border-raidus in Firefox (ant-design#16957)

* Revert "Merge pull request ant-design#16174 from ant-design/fix-table-chrome"

This reverts commit 686c1fc, reversing
changes made to 924afc2.

* firefox only

* add comment

*  update snapshots

* 馃啓 upgrade all deps to latest version

* 馃啓 fix for typescript@3.5

* 馃敡 ignore other files for packtracker

* Suppress autoprefixer warning

* add new less var

* less variable should be extended

*  Fix ci

* 馃摑 Add FAQ for DatePicker/RangePicker mode prop usage

* fix packtracker exclude_assets

* 馃悰 Fix Divider `orientation="center"` style

close ant-design#16987

* Add missing spanish translations

* Export TextProps and update english in error

*  Fix test snapshots

* Fix typo

* Update colors.zh-CN.md

* docs: 3.19.3 change-log (ant-design#16998)

* chore: update package.json

* fix: Table with sort should reset to first page (ant-design#17020)

* sort reset pagination

* add test case

* 馃悰 Fix margin issue of PageHeader extra

close ant-design#17025

* 猬嗭笍 Update majo requirement from ^0.7.1 to ^0.8.0

Updates the requirements on [majo](https://github.com/egoist/majo) to permit the latest version.
- [Release notes](https://github.com/egoist/majo/releases)
- [Commits](egoist/majo@v0.7.1...v0.8.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* 馃悰 Fix margin issue of PageHeader extra continually

* update calendar (ant-design#17038)

* 馃拕 Keep submenu selected style

* Update index.less

* Update default.less

* Update certain-category.md

* Update uncertain-category.md

*  update snapshots

* 馃摑 Fix image in feedback spec documentation

*  update snapshots

* use calc to fix tree line (ant-design#17055)

* fix: add link button to basic demo of button docs

* 馃拕 adjust bordered table header scrollbar style

* 馃拕 optimize bordered table header scrollbar style

continue after ant-design#17065

* Fix grammar on message documentation

* fix: remove margin for collapse arrow (ant-design#17009)

* remove margin for collapse arrow

* change translateY to -21px in collapse

* remove line-height to center arrow

* Fixing date formats for Arabic-Egypt locale

* Update index.zh-CN.md

add getPopupContainer props

* 馃悰 Fix Input not align with other components in Chrome

close ant-design#17082

@yesmeck yesmeck referenced this pull request Jun 15, 2019

Merged

Add 3.19.4 changelog #17115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.