Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Keep submenu selected style #17039

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented Jun 11, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

image

💡 Solution

image

📝 Changelog

Language Changelog
🇺🇸 English Menu 子菜单选中收起时也应该有高亮样式。
🇨🇳 Chinese Menu.SubMenu with selected item should have active style

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #17039 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17039   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         263      263           
  Lines        7340     7340           
  Branches     2048     2050    +2     
=======================================
  Hits         7044     7044           
  Misses        294      294           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d3041...20e6bed. Read the comment docs.

@afc163 afc163 merged commit 1b20b3b into master Jun 11, 2019

24 of 27 checks passed

LGTM analysis: JavaScript No code changes detected
Details
packtracker/css 480 KB — ▲ 0.01%
Details
packtracker/javascript 1.83 MB — No Change
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 826.75 KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 61d3041...20e6bed
Details
codecov/project 95.96% remains the same compared to 61d3041
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 11, 2019

@delete-merged-branch delete-merged-branch bot deleted the style-submenu-selected branch Jun 11, 2019

@yesmeck yesmeck referenced this pull request Jun 15, 2019

Merged

Add 3.19.4 changelog #17115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.