Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Keep submenu selected style #17039

Merged
merged 1 commit into from Jun 11, 2019
Merged

style: Keep submenu selected style #17039

merged 1 commit into from Jun 11, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 11, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

image

close #16866

💡 Solution

image

📝 Changelog

Language Changelog
🇺🇸 English Menu 子菜单选中收起时也应该有高亮样式。
🇨🇳 Chinese Menu.SubMenu with selected item should have active style

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

@codecov codecov bot commented Jun 11, 2019

Codecov Report

Merging #17039 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17039   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files         263      263           
  Lines        7340     7340           
  Branches     2048     2050    +2     
=======================================
  Hits         7044     7044           
  Misses        294      294           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d3041...20e6bed. Read the comment docs.

@afc163 afc163 merged commit 1b20b3b into master Jun 11, 2019
27 checks passed
@delete-merged-branch delete-merged-branch bot deleted the style-submenu-selected branch Jun 11, 2019
@yesmeck yesmeck mentioned this pull request Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant