Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: less variables for comment component font-size #17041

Merged
merged 2 commits into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@SamKirkland
Copy link
Contributor

commented Jun 11, 2019

馃 This is a ...

  • Bug fix

馃懟 What's the background?

The comment component used hard-coded font-sizes in it's .less file instead of using the font-sizes defined in default.less

馃挕 Solution

I added 2 new font-size less vars in default.less (following existing patterns) and set them the the default font-size set in the theme.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Comment component font-size less variables
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

SamKirkland added some commits Jun 11, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Jun 11, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #17041 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17041      +/-   ##
==========================================
+ Coverage   95.96%      96%   +0.04%     
==========================================
  Files         263      263              
  Lines        7340     7340              
  Branches     2009     2009              
==========================================
+ Hits         7044     7047       +3     
+ Misses        294      291       -3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 88.67% <0%> (+2.83%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1b20b3b...7b3f055. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #17041 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17041      +/-   ##
==========================================
+ Coverage   95.96%      96%   +0.04%     
==========================================
  Files         263      263              
  Lines        7340     7340              
  Branches     2009     2009              
==========================================
+ Hits         7044     7047       +3     
+ Misses        294      291       -3     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 88.67% <0%> (+2.83%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1b20b3b...7b3f055. Read the comment docs.

@afc163 afc163 merged commit 2818dde into ant-design:master Jun 11, 2019

23 of 26 checks passed

LGTM analysis: JavaScript No code changes detected
Details
packtracker/css 480 KB 鈥 No Change
Details
packtracker/javascript 1.83 MB 鈥 No Change
Details
CodeFactor No issues found.
Details
DEP All dependencies are resolved
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1b20b3b...7b3f055
Details
codecov/project 96% (+0.04%) compared to 1b20b3b
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 11, 2019

@yesmeck yesmeck referenced this pull request Jun 15, 2019

Merged

Add 3.19.4 changelog #17115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.