Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve time picker accessibility #17099

Merged
merged 2 commits into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Jun 14, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

react-component/time-picker#153
react-component/time-picker#154

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Enhance TimePicker accessibility
🇨🇳 Chinese 增强 TimePicker 的键盘可访问性支持。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/popconfirm/index.en-US.md
View rendered components/popconfirm/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Jun 14, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Jun 14, 2019

Deploy preview for ant-design ready!

Built with commit a62a3e9

https://deploy-preview-17099--ant-design.netlify.com

@afc163 afc163 changed the base branch from master to feature Jun 14, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 14, 2019

Codecov Report

Merging #17099 into feature will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17099      +/-   ##
===========================================
- Coverage    95.96%   95.96%   -0.01%     
===========================================
  Files          263      263              
  Lines         7343     7332      -11     
  Branches      2049     2047       -2     
===========================================
- Hits          7047     7036      -11     
  Misses         294      294              
  Partials         2        2
Impacted Files Coverage Δ
components/breadcrumb/Breadcrumb.tsx 96.07% <0%> (-0.54%) ⬇️
components/table/Table.tsx 93.41% <0%> (-0.06%) ⬇️
components/cascader/index.tsx 96.9% <0%> (ø) ⬆️
components/transfer/list.tsx 94.33% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5382c1...8ac2024. Read the comment docs.

@afc163 afc163 changed the title Improve time picker accessibility feat: Improve time picker accessibility Jun 14, 2019

@afc163 afc163 merged commit 6a10951 into feature Jun 14, 2019

4 of 8 checks passed

packtracker/css Awaiting your base commit report...
Details
packtracker/javascript Awaiting your base commit report...
Details
License Compliance FOSSA is analyzing this commit
Details
ci/circleci: setup Your tests are queued behind your running builds
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 14, 2019

@delete-merged-branch delete-merged-branch bot deleted the improve-time-picker-accessibility branch Jun 14, 2019

@afc163 afc163 referenced this pull request Jun 29, 2019

Closed

add 3.20.0 changelog #17362

5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.