Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RangerPicker style #17126

Merged
merged 2 commits into from Jun 17, 2019

Conversation

Projects
None yet
8 participants
@zombieJ
Copy link
Member

commented Jun 17, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

灞忓箷蹇収 2019-06-17 涓婂崍9 45 04

close #17124
close #17123

馃挕 Solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix RangerPicker input style not align
馃嚚馃嚦 Chinese 淇 RangerPicker 杈撳叆妗嗗唴瀹规病鏈夊榻愮殑闂

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 17, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 17, 2019

Deploy preview for ant-design ready!

Built with commit cc4f1d7

https://deploy-preview-17126--ant-design.netlify.com

@afc163

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

Rebase master after #17128 merged

@codecov

This comment has been minimized.

Copy link

commented Jun 17, 2019

Codecov Report

Merging #17126 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17126      +/-   ##
==========================================
- Coverage   95.96%   95.95%   -0.02%     
==========================================
  Files         263      263              
  Lines        7344     7344              
  Branches     2050     2050              
==========================================
- Hits         7048     7047       -1     
- Misses        294      295       +1     
  Partials        2        2
Impacted Files Coverage 螖
components/_util/wave.tsx 85.84% <0%> (-2.84%) 猬囷笍
components/back-top/index.tsx 92.06% <0%> (+3.17%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e0bfcab...cc4f1d7. Read the comment docs.

@zombieJ zombieJ merged commit dc1572c into master Jun 17, 2019

24 of 30 checks passed

License Compliance FOSSA is analyzing this commit
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 216 new files uploaded
Details
packtracker/css 481 KB 鈥 鈻 0.00%
Details
packtracker/javascript 1.83 MB 鈥 No Change
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e0bfcab...cc4f1d7
Details
codecov/project 95.95% (-0.02%) compared to e0bfcab
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 17, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-date-ranger branch Jun 17, 2019

@zombieJ zombieJ referenced this pull request Jun 17, 2019

Merged

chore: 3.19.5 changelog #17133

1 of 10 tasks complete
@lcx-seima

This comment has been minimized.

Copy link

commented Jun 17, 2019

鎴戠湅 commit 鍙敼浜 ant-calendar-range-picker-inputant-calendar-range-picker-separator 涔熸敼浜嗗惂锛

@beMySun

This comment has been minimized.

Copy link

commented Jun 17, 2019

Still not working in 3.19.5.

image

3.18.1 is Good.

image

@afc163

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

纭疄锛宻eparator 杩樺湪涓嬮潰銆

@wangjianio

This comment has been minimized.

Copy link

commented Jun 18, 2019

淇涔嬪墠鍏堢敤 3.19.3 鍚э紝鏈杩戝彂鐗堟湁鐐归绻佸晩

@ZhiGang-Fang

This comment has been minimized.

Copy link

commented Jun 19, 2019

www

璧惰剼杩樻槸瀵诲湪闂

@jackple

This comment has been minimized.

Copy link

commented Jun 21, 2019

@afc163
閲嶈鐨勬槸璺熷叾浠杅orm缁勪欢涓嶅榻愪簡, 杩欎釜褰卞搷姣3.19.5鐨勪慨澶嶇殑鍐呭鏇村ぇ
image

@billwing

This comment has been minimized.

Copy link

commented Jun 21, 2019

@jackple 鎴戜篃鍦ㄧ湅杩欎釜闂锛屽垰杩樺師鍒3.19.3浜馃槀

@zombieJ

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

@jackple @billwing 杩欎釜 fix 宸茬粡 revert 浜嗐3.19.6 杩樻湁杩欎釜闂鍚楋紵

@billwing

This comment has been minimized.

Copy link

commented Jun 21, 2019

@zombieJ 鍒氭洿鏂板埌3.19.6锛屾病鏈夊彂鐜拌繖涓棶棰馃

@jackple

This comment has been minimized.

Copy link

commented Jun 21, 2019

@zombieJ 鎴戝皾璇曞崌绾у悗鐪嬪埌杩欐牱灏卞洖婊氫簡, 绋嶅欐垜鍐嶇湅鐪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.