Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: `getPopupContainer` of ConfigProvider not works on Modal #17132

Merged
merged 1 commit into from Jun 17, 2019

Conversation

Projects
None yet
1 participant
@zombieJ
Copy link
Member

commented Jun 17, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

getPopupContainer of ConfigProvider not works on Modal

💡 Solution

Update logic

📝 Changelog

Language Changelog
🇺🇸 English Fix getPopupContainer of ConfigProvider not works on Modal
🇨🇳 Chinese 修复 ConfigProvider 的 getPopupContainer 对 Modal 无效的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 17, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 17, 2019

Deploy preview for ant-design ready!

Built with commit 17258c7

https://deploy-preview-17132--ant-design.netlify.com

@zombieJ zombieJ referenced this pull request Jun 17, 2019

Merged

chore: 3.19.5 changelog #17133

1 of 10 tasks complete

@zombieJ zombieJ changed the title Fix: `getPopupContainer` of ConfigProvider not works on Modal fix: `getPopupContainer` of ConfigProvider not works on Modal Jun 17, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 17, 2019

Codecov Report

Merging #17132 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17132      +/-   ##
==========================================
+ Coverage   95.95%   95.95%   +<.01%     
==========================================
  Files         263      263              
  Lines        7344     7346       +2     
  Branches     2037     2049      +12     
==========================================
+ Hits         7047     7049       +2     
  Misses        295      295              
  Partials        2        2
Impacted Files Coverage Δ
components/modal/Modal.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1572c...17258c7. Read the comment docs.

@zombieJ zombieJ merged commit b402517 into master Jun 17, 2019

27 of 31 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
packtracker/css 481 KB — No Change
Details
packtracker/javascript 1.83 MB — ▲ 0.00%
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.95%)
Details
codecov/project 95.95% (+<.01%) compared to dc1572c
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 17, 2019

@delete-merged-branch delete-merged-branch bot deleted the modal-config branch Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.