Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nest Card extra position not correct #17140

Merged
merged 2 commits into from Jun 17, 2019

Conversation

Projects
None yet
2 participants
@zombieJ
Copy link
Member

commented Jun 17, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

fix #17077

💡 Solution

Adjust style

📝 Changelog

Language Changelog
🇺🇸 English Fix nest Card extra position not correct.
🇨🇳 Chinese 修复嵌套 Card extra 位置不正确的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 17, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 17, 2019

Deploy preview for ant-design ready!

Built with commit 5ca67f6

https://deploy-preview-17140--ant-design.netlify.com

@@ -109,7 +109,7 @@
padding-bottom: 0;
}

&-contain-tabs &-extra {
&-contain-tabs &-head &-extra {

This comment has been minimized.

Copy link
@afc163

afc163 Jun 17, 2019

Member

这样貌似不解决问题。

@codecov

This comment has been minimized.

Copy link

commented Jun 17, 2019

Codecov Report

Merging #17140 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17140   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7346     7346           
  Branches     2010     2038   +28     
=======================================
  Hits         7049     7049           
  Misses        295      295           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfe4de5...5ca67f6. Read the comment docs.

@afc163

afc163 approved these changes Jun 17, 2019

@zombieJ zombieJ merged commit ebdc704 into master Jun 17, 2019

25 of 30 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 216 new files uploaded
Details
packtracker/css 481 KB — ▲ 0.00%
Details
packtracker/javascript 1.83 MB — No Change
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing cfe4de5...5ca67f6
Details
codecov/project 95.95% remains the same compared to cfe4de5
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the nest-card branch Jun 17, 2019

@zombieJ zombieJ referenced this pull request Jun 19, 2019

Merged

docs: 3.19.6 changelog #17166

1 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.