Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong height of TextArea & DatePicker #17165

Merged
merged 1 commit into from Jun 19, 2019

Conversation

Projects
None yet
3 participants
@zombieJ
Copy link
Member

commented Jun 19, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

fix #17163
fix #17143
fix #17159

💡 Solution

Reset line-height back

📝 Changelog

Language Changelog
🇺🇸 English Fix wrong height of TextArea & DatePicker
🇨🇳 Chinese 修复 TextArea 和 DatePicker 的高度问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 19, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 19, 2019

Deploy preview for ant-design ready!

Built with commit d9b4b7d

https://deploy-preview-17165--ant-design.netlify.com

@zombieJ zombieJ requested a review from afc163 Jun 19, 2019

@afc163

afc163 approved these changes Jun 19, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

close #17159

@codecov

This comment has been minimized.

Copy link

commented Jun 19, 2019

Codecov Report

Merging #17165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17165   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7348     7348           
  Branches     2051     2053    +2     
=======================================
  Hits         7051     7051           
  Misses        295      295           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a676f37...d9b4b7d. Read the comment docs.

@zombieJ zombieJ merged commit dc4102d into master Jun 19, 2019

26 of 29 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 833.71 KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a676f37...d9b4b7d
Details
codecov/project 95.95% remains the same compared to a676f37
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-line-height branch Jun 19, 2019

@zombieJ zombieJ referenced this pull request Jun 19, 2019

Merged

docs: 3.19.6 changelog #17166

1 of 10 tasks complete
@msingleton

This comment has been minimized.

Copy link

commented Jun 19, 2019

Thanks for the quick fix @zombieJ !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.