Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix single Breadcrumb not show on PageHeader #17209

Merged
merged 2 commits into from Jun 21, 2019

Conversation

Projects
None yet
3 participants
@chenshuai2144
Copy link
Contributor

commented Jun 20, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

只有在大于等于 2 个的情况下面包屑才会显示

💡 Solution

close #17046

📝 Changelog

Language Changelog
🇺🇸 English Fix single Breadcrumb not show on PageHeader
🇨🇳 Chinese 修复单个 Breadcrumb 未在 PageHeader 上显示的问题

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 20, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 20, 2019

Deploy preview for ant-design ready!

Built with commit 7e548e4

https://deploy-preview-17209--ant-design.netlify.com

add new test
when breadcrumb lenght=1, pageHeader should have breadcrumb
@codecov

This comment has been minimized.

Copy link

commented Jun 20, 2019

Codecov Report

Merging #17209 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17209      +/-   ##
==========================================
+ Coverage   95.95%   95.99%   +0.04%     
==========================================
  Files         263      263              
  Lines        7348     7348              
  Branches     2051     2013      -38     
==========================================
+ Hits         7051     7054       +3     
+ Misses        295      292       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/page-header/index.tsx 100% <100%> (ø) ⬆️
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2732ee...7e548e4. Read the comment docs.

@chenshuai2144 chenshuai2144 changed the title fix #17046, breadcrumbs will always show bugfix: fix #17046, breadcrumbs will always show Jun 20, 2019

@chenshuai2144 chenshuai2144 changed the title bugfix: fix #17046, breadcrumbs will always show fix: fix #17046, breadcrumbs will always show Jun 20, 2019

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

Fix single Breadcrumb not show on PageHeader

@chenshuai2144 chenshuai2144 changed the title fix: fix #17046, breadcrumbs will always show fix: breadcrumbs will always show Jun 20, 2019

@chenshuai2144 chenshuai2144 changed the title fix: breadcrumbs will always show fix: Fix single Breadcrumb not show on PageHeader Jun 20, 2019

@afc163 afc163 merged commit 0a7432e into master Jun 21, 2019

27 of 29 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 215 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.95%)
Details
codecov/project 95.99% (+0.04%) compared to e2732ee
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 21, 2019

@delete-merged-branch delete-merged-branch bot deleted the pageheader-show-all-breadcrumb branch Jun 21, 2019

@afc163 afc163 referenced this pull request Jun 21, 2019

Merged

docs: release 3.19.7 #17227

@chenshuai2144 chenshuai2144 referenced this pull request Jun 22, 2019

Merged

修复一些 bug #28

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.