Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table scrollbar style in IE #17223

Merged
merged 1 commit into from Jun 21, 2019

Conversation

Projects
None yet
1 participant
@afc163
Copy link
Member

commented Jun 21, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

When customize line-height of empty table.

close #17175

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Fix one scrollbar style bug of empty Table in IE.
🇨🇳 Chinese 修复空数据 Table 在 IE 下的一个滚动条样式问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
🐛 Fix a Table scrollbar style in IE
when customize line-height of empty table

close #17175

@pr-triage pr-triage bot added the PR: unreviewed label Jun 21, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 21, 2019

Deploy preview for ant-design ready!

Built with commit bdfd877

https://deploy-preview-17223--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Jun 21, 2019

Codecov Report

Merging #17223 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17223      +/-   ##
==========================================
- Coverage      96%   95.95%   -0.05%     
==========================================
  Files         263      263              
  Lines        7350     7350              
  Branches     2014     2014              
==========================================
- Hits         7056     7053       -3     
- Misses        292      295       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c85ea...bdfd877. Read the comment docs.

@afc163 afc163 merged commit 5c909e3 into master Jun 21, 2019

26 of 29 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No prior size to compare - 834.16 KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 07c85ea...bdfd877
Details
codecov/project 95.95% (-0.05%) compared to 07c85ea
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 21, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-table-scrollbar-in-IE branch Jun 21, 2019

@afc163 afc163 referenced this pull request Jun 21, 2019

Merged

docs: release 3.19.7 #17227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.