Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal 24px bottom area not trigger mask click #17229

Merged
merged 1 commit into from Jun 21, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 21, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17226

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Modal 24px bottom area cannot trigger mask click event.
🇨🇳 Chinese 修复 Modal 底部 24px 像素遮罩区域无法触发关闭弹窗行为。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jun 21, 2019

Deploy preview for ant-design ready!

Built with commit 0ea94b9

https://deploy-preview-17229--ant-design.netlify.com

@afc163 afc163 mentioned this pull request Jun 21, 2019
ztplz
ztplz approved these changes Jun 21, 2019
@codecov
Copy link

@codecov codecov bot commented Jun 21, 2019

Codecov Report

No coverage uploaded for pull request base (master@a4d7593). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17229   +/-   ##
=========================================
  Coverage          ?   95.95%           
=========================================
  Files             ?      263           
  Lines             ?     7350           
  Branches          ?     2014           
=========================================
  Hits              ?     7053           
  Misses            ?      295           
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d7593...0ea94b9. Read the comment docs.

@afc163 afc163 merged commit 606ed90 into master Jun 21, 2019
29 checks passed
@delete-merged-branch delete-merged-branch bot deleted the adjust-modal-padding-bottom branch Jun 21, 2019
hashplus
Copy link

@hashplus hashplus commented on 0ea94b9 Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个修改导致modal中下拉列表无法点击

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented on 0ea94b9 Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上demo来看看。

hashplus
Copy link

@hashplus hashplus commented on 0ea94b9 Nov 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上demo来看看。

https://codesandbox.io/s/great-gould-2txjj

<AutoComplete
  defaultValue="lucy"
  // 把下面注释删除,下拉列表就没法点选。如果不添加下面一行,下拉列表就不能跟随页面滚动。
  // getPopupContainer={() => document.querySelector(".ant-modal")}
>

这块getPopupContainer取其他元素就能避免这个问题了,只要不是.ant-modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants