Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal 24px bottom area not trigger mask click #17229

Merged
merged 1 commit into from Jun 21, 2019

Conversation

Projects
None yet
3 participants
@afc163
Copy link
Member

commented Jun 21, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17226

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Modal 24px bottom area cannot trigger mask click event.
🇨🇳 Chinese 修复 Modal 底部 24px 像素遮罩区域无法触发关闭弹窗行为。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 21, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 21, 2019

Deploy preview for ant-design ready!

Built with commit 0ea94b9

https://deploy-preview-17229--ant-design.netlify.com

@afc163 afc163 referenced this pull request Jun 21, 2019

Merged

docs: release 3.19.7 #17227

@ztplz

ztplz approved these changes Jun 21, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 21, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@a4d7593). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17229   +/-   ##
=========================================
  Coverage          ?   95.95%           
=========================================
  Files             ?      263           
  Lines             ?     7350           
  Branches          ?     2014           
=========================================
  Hits              ?     7053           
  Misses            ?      295           
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d7593...0ea94b9. Read the comment docs.

@afc163 afc163 merged commit 606ed90 into master Jun 21, 2019

26 of 29 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 216 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the adjust-modal-padding-bottom branch Jun 21, 2019

@hashplus

This comment has been minimized.

Copy link

commented on 0ea94b9 Jul 17, 2019

这个修改导致modal中下拉列表无法点击

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.