Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Tooltip arrow shadow #17264

Merged
merged 1 commit into from Jun 25, 2019
Merged

style: fix Tooltip arrow shadow #17264

merged 1 commit into from Jun 25, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 24, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17259

💡 Solution

same as #13935

📝 Changelog

Language Changelog
🇺🇸 English Fix Tooltip arrow shadow style.
🇨🇳 Chinese 修复 Tooltip 箭头阴影样式。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jun 24, 2019

Deploy preview for ant-design ready!

Built with commit 2183ffc

https://deploy-preview-17264--ant-design.netlify.com

@afc163 afc163 changed the title 💄 Fix Tooltip arrow shadow [WIP] fix Tooltip arrow shadow Jun 24, 2019
@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #17264 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17264      +/-   ##
==========================================
+ Coverage   95.95%      96%   +0.04%     
==========================================
  Files         263      263              
  Lines        7351     7351              
  Branches     2042     2055      +13     
==========================================
+ Hits         7054     7057       +3     
+ Misses        295      292       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f913f...2183ffc. Read the comment docs.

bottom: @tooltip-distance - @tooltip-arrow-width + 2.2px;
border-top-color: transparent;
border-right-color: tint(fadein(@tooltip-bg, 100%), 25%); // make it not transparent
border-bottom-color: tint(fadein(@tooltip-bg, 100%), 25%); // make it not transparent
Copy link
Member Author

@afc163 afc163 Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tooltip 有透明度,需要有这种方式去除箭头透明度,否则和卡片叠加会有黑边出现。

@afc163 afc163 changed the title [WIP] fix Tooltip arrow shadow style fix Tooltip arrow shadow Jun 24, 2019
@afc163 afc163 changed the title style fix Tooltip arrow shadow style: fix Tooltip arrow shadow Jun 24, 2019
@afc163 afc163 requested a review from zombieJ Jun 24, 2019
border-style: solid;
border-width: sqrt(@tooltip-arrow-width * @tooltip-arrow-width * 2) / 2;
transform: rotate(45deg);
Copy link
Member

@zombieJ zombieJ Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

666,发我数学退步了,一下子都反应不过来。

@zombieJ zombieJ merged commit 868cd61 into master Jun 25, 2019
29 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tweak-tooltip-style branch Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants