Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Tooltip arrow shadow #17264

Merged
merged 1 commit into from Jun 25, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Jun 24, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17259

💡 Solution

same as #13935

📝 Changelog

Language Changelog
🇺🇸 English Fix Tooltip arrow shadow style.
🇨🇳 Chinese 修复 Tooltip 箭头阴影样式。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 24, 2019

@netlify

This comment has been minimized.

Copy link

commented Jun 24, 2019

Deploy preview for ant-design ready!

Built with commit 2183ffc

https://deploy-preview-17264--ant-design.netlify.com

@afc163 afc163 changed the title :lipstick: Fix Tooltip arrow shadow [WIP] fix Tooltip arrow shadow Jun 24, 2019

@pr-triage pr-triage bot removed the PR: unreviewed label Jun 24, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 24, 2019

Codecov Report

Merging #17264 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17264      +/-   ##
==========================================
+ Coverage   95.95%      96%   +0.04%     
==========================================
  Files         263      263              
  Lines        7351     7351              
  Branches     2042     2055      +13     
==========================================
+ Hits         7054     7057       +3     
+ Misses        295      292       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f913f...2183ffc. Read the comment docs.

@afc163 afc163 force-pushed the tweak-tooltip-style branch from 22d649e to 2183ffc Jun 24, 2019

bottom: @tooltip-distance - @tooltip-arrow-width + 2.2px;
border-top-color: transparent;
border-right-color: tint(fadein(@tooltip-bg, 100%), 25%); // make it not transparent
border-bottom-color: tint(fadein(@tooltip-bg, 100%), 25%); // make it not transparent

This comment has been minimized.

Copy link
@afc163

afc163 Jun 24, 2019

Author Member

tooltip 有透明度,需要有这种方式去除箭头透明度,否则和卡片叠加会有黑边出现。

@afc163 afc163 changed the title [WIP] fix Tooltip arrow shadow style fix Tooltip arrow shadow Jun 24, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Jun 24, 2019

@afc163 afc163 changed the title style fix Tooltip arrow shadow style: fix Tooltip arrow shadow Jun 24, 2019

@afc163 afc163 requested a review from zombieJ Jun 24, 2019

border-style: solid;
border-width: sqrt(@tooltip-arrow-width * @tooltip-arrow-width * 2) / 2;
transform: rotate(45deg);

This comment has been minimized.

Copy link
@zombieJ

zombieJ Jun 25, 2019

Member

666,发我数学退步了,一下子都反应不过来。

@zombieJ zombieJ merged commit 868cd61 into master Jun 25, 2019

26 of 29 checks passed

Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 217 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 25f913f...2183ffc
Details
codecov/project 96% (+0.04%) compared to 25f913f
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Jun 25, 2019

@delete-merged-branch delete-merged-branch bot deleted the tweak-tooltip-style branch Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.