Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Descriptions.Item not support className #17280

Merged
merged 4 commits into from Jun 26, 2019

Conversation

Projects
None yet
3 participants
@afc163
Copy link
Member

commented Jun 24, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #17234

馃挕 Solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix Desciptions.Item not support className
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Jun 24, 2019

Deploy preview for ant-design ready!

Built with commit d997a14

https://deploy-preview-17280--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Jun 24, 2019

Codecov Report

Merging #17280 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17280   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7351     7351           
  Branches     2015     2015           
=======================================
  Hits         7054     7054           
  Misses        295      295           
  Partials        2        2
Impacted Files Coverage 螖
components/descriptions/index.tsx 98.66% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 795e6a5...d997a14. Read the comment docs.

@yoyo837
Copy link
Contributor

left a comment

杩欐牱杩欎釜className鐨勫畾涔夋劅瑙変笉鏄庣‘鏄笉鏄痠tem鐨勶紝鍥犱负bordered鏃跺張鏄簲鐢ㄥ埌label锛宑ontent涓

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

杩欐牱杩欎釜className鐨勫畾涔夋劅瑙変笉鏄庣‘鏄笉鏄痠tem鐨勶紝鍥犱负bordered鏃跺張鏄簲鐢ㄥ埌label锛宑ontent涓

鍡紝鎰熻鏄湁鐐规紓涓嶈繃鐩墠鐪嬩篃娌℃湁鏇村ソ鐨勬柟寮忎簡銆

@yoyo837

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

浼氫笉浼氱洿鎺ユ彁渚沴abel鍜宑ontent鍚勮嚜鐨刢lassName灏卞畾涔夋槑纭簡浜涘憿锛岃屼笖涓ょ閮芥敮鎸併

@yoyo837

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

姣斿鏈変釜props鏄垏鎹ordered鐨勶紝濡傛灉鎸夎繖涓狿R澶勭悊鐨勮瘽锛屼娇鐢ㄧ殑闇瑕佸悓鏃跺垏鎹lassName鐨勪紶鍏ワ紝鍥犱负item鏄痠tem锛宭abel鏄痩abel锛宑ontent鏄痗ontent...

@afc163 鑰佹澘鍐崇瓥鍚э紝鍙槸涓涓娇鐢ㄤ笂鐨勫皬case銆

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

鍏堜笉鐢紝鏈 issue 鐨勮瘽鍐嶇湅鐪嬨俛pi 澶氫簡骞朵笉鏄竴浠跺ソ浜嬨

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

鍙互寮勬垚 th.className td.className锛岃繖鏍蜂篃閫夋嫨寰楀埌銆

@yoyo837

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@zombieJ 鎴戞湰浜烘鏄湪鎻愬嚭姝ょ枒闂紝娌″紑issue鑰屽凡銆傚啀鑰咃紝濡傛灉鏈塱ssue 鍐嶆敼灏辨槸break change浜嗗憿銆

@zombieJ

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

鎴戜笂闈㈣繖涓缓璁憿锛th td 鍖哄垎

@yoyo837

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@zombieJ 瀵逛簬Descriptions鎻忚堪鍒楄〃 缁勪欢鏈韩鏉ヨ锛宼able鍙槸浠栫殑DOM瀹炵幇鏂瑰紡锛屾槸鍚﹀簲璇ュ敖閲忎笉鍦ˋPI 鏆撮湶杩欎釜姒傚康鍑哄幓浜嗭紝姣斿鏈変竴澶╁洜鏁呮敼涓篸iv瀹炵幇銆

浜︽垨鏄垜娌$悊瑙e鎰忔濄

[size as string]: size !== 'default',
bordered,
[`${prefixCls}-${size}`]: size !== 'default',
[`${prefixCls}-bordered`]: !!bordered,

This comment has been minimized.

Copy link
@afc163

afc163 Jun 25, 2019

Author Member

浣跨敤鏇寸簿纭殑绫诲悕锛屽苟浼樺寲浜嗘牱寮忓疄鐜般

}
.@{descriptions-prefix-cls}-item-content {
float: left;
padding: 0 !important;

This comment has been minimized.

Copy link
@afc163

afc163 Jun 25, 2019

Author Member

鍘绘帀涓嶅繀瑕佺殑娴姩鍜 !important;

@afc163

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

  • labelcontent 鍗曠嫭缁 className 鏄竴涓В鍐虫柟妗堬紝浣嗘槸鐢ㄦ埛鏇撮鏈熸洿澶氱殑鏄粰鏁翠釜 item 娣诲姞鏍峰紡锛岃屼笉鏄崟鐙坊鍔犮
  • 鎵浠ヨ繖閲岃繕鏄洿鎺ョ粰 td 鍔 className銆
  • 瀵逛簬 bordered 鍦烘櫙涓よ呮湁浜涘尯鍒殑闂锛岀‘瀹炶泲鐤硷紝浣嗘槸鍔ㄦ佸垏鎹㈢殑鍦烘櫙寰堝皯锛屽彲浠ユ帴鍙椼
  • 鎶 label 鐨勯粯璁 element 鏀规垚 th锛岃涔変笂鏇存竻鏅帮紝鑷畾涔夋牱寮忔椂涔熸柟渚夸竴鐐广傦紙css-modules 涓嬪啓 .ant-descriptions-item-label 杩橀渶瑕佸寘瑁 :global()锛夈
@afc163

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

鎰熻阿 @yoyo837 鐨勫缓璁

@yoyo837

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@zombieJ 鐪嬩簡鑰佹澘鐨刢ommits鎵嶇煡閬撲綘璇寸殑th, td鏄粈涔堟剰鎬. 馃檭

afc163 added some commits Jun 24, 2019

@afc163 afc163 force-pushed the fix-descrptions-classname branch from 862971d to d997a14 Jun 25, 2019

@zombieJ zombieJ merged commit 94072ad into master Jun 26, 2019

25 of 27 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 217 new files uploaded
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.95%)
Details
codecov/project 95.95% (+0%) compared to 795e6a5
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot removed the PR: unreviewed label Jun 26, 2019

@pr-triage pr-triage bot added the PR: merged label Jun 26, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-descrptions-classname branch Jun 26, 2019

chenshuai2144 added a commit that referenced this pull request Jun 28, 2019

update snap
issue in #17280 and #17330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.