Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: progress circle add support gradient #17315

Merged
merged 2 commits into from Jun 26, 2019

Conversation

Projects
None yet
2 participants
@hengkx
Copy link
Contributor

commented Jun 26, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

close #17286

image

📝 Changelog

Language Changelog
🇺🇸 English Progress.Circle support gradient line color
🇨🇳 Chinese Progress.Circle 支持渐变色

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/progress/demo/gradient-circle.md
View rendered components/progress/index.en-US.md
View rendered components/progress/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Jun 26, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

预期的 changelog 麻烦帮忙写一下。

@afc163

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

ts 定义也需要更新一下。

@hengkx

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

ts 定义也需要更新一下。

这个ts定义和之前的是一样的,changelog 我改下

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #17315 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17315      +/-   ##
===========================================
+ Coverage    95.96%   95.96%   +<.01%     
===========================================
  Files          263      263              
  Lines         7356     7359       +3     
  Branches      2054     2054              
===========================================
+ Hits          7059     7062       +3     
  Misses         295      295              
  Partials         2        2
Impacted Files Coverage Δ
components/progress/Circle.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed8e85...2a42432. Read the comment docs.

2 similar comments
@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #17315 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17315      +/-   ##
===========================================
+ Coverage    95.96%   95.96%   +<.01%     
===========================================
  Files          263      263              
  Lines         7356     7359       +3     
  Branches      2054     2054              
===========================================
+ Hits          7059     7062       +3     
  Misses         295      295              
  Partials         2        2
Impacted Files Coverage Δ
components/progress/Circle.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed8e85...2a42432. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #17315 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17315      +/-   ##
===========================================
+ Coverage    95.96%   95.96%   +<.01%     
===========================================
  Files          263      263              
  Lines         7356     7359       +3     
  Branches      2054     2054              
===========================================
+ Hits          7059     7062       +3     
  Misses         295      295              
  Partials         2        2
Impacted Files Coverage Δ
components/progress/Circle.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed8e85...2a42432. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #17315 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17315      +/-   ##
===========================================
+ Coverage    95.96%   95.96%   +<.01%     
===========================================
  Files          263      263              
  Lines         7356     7359       +3     
  Branches      2054     2054              
===========================================
+ Hits          7059     7062       +3     
  Misses         295      295              
  Partials         2        2
Impacted Files Coverage Δ
components/progress/Circle.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fed8e85...c1a2172. Read the comment docs.

@hengkx

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

image

@afc163

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

高大上!

@afc163 afc163 changed the title Feature progress circle add support gradient feat: progress circle add support gradient Jun 26, 2019

@afc163

afc163 approved these changes Jun 26, 2019

@afc163 afc163 merged commit 6d26675 into ant-design:feature Jun 26, 2019

23 checks passed

DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.96%)
Details
codecov/project 95.96% (+<.01%) compared to fed8e85
Details
security/snyk - package.json (paranoidjk) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.