Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add maskClosable is false ESC close #17316

Merged
merged 2 commits into from Jun 27, 2019

Conversation

Projects
None yet
2 participants
@jljsj33
Copy link
Member

commented Jun 26, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English 写不来
🇨🇳 Chinese - 修复 maskCloseble 为 false, 键盘 ESC 关闭无效, #16883。
- API 新增 keyboard, 允许控制是否有键盘关闭事件。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/drawer/index.en-US.md
View rendered components/drawer/index.zh-CN.md

#16905

@jljsj33 jljsj33 requested a review from afc163 Jun 26, 2019

@pr-triage pr-triage bot added the PR: unreviewed label Jun 26, 2019

@afc163

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

changelog 写下

@jljsj33

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

写了。。英文你翻译一下。。

@afc163

afc163 approved these changes Jun 26, 2019

@afc163 afc163 merged commit 05feaeb into feature Jun 27, 2019

24 of 25 checks passed

security/snyk - package.json (paranoidjk) Test in progress
CodeFactor No issues found.
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.96%)
Details
codecov/project 96% (+0.03%) compared to 65eb713
Details

@delete-merged-branch delete-merged-branch bot deleted the key-drawer branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.