Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Optimize PageHeader className naming #17321

Merged
merged 2 commits into from Jun 28, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Jun 26, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

优化 PageHeader 类名的可读性,.ant-page-header-title-view-title 这样的实在是太恶心了。

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Optimize PageHeader className naming.
🇨🇳 Chinese 优化 PageHeader 类名的可读性。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/popconfirm/index.en-US.md
View rendered components/popconfirm/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Jun 26, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Jun 26, 2019

Deploy preview for ant-design ready!

Built with commit c0fa2fc

https://deploy-preview-17321--ant-design.netlify.com

@afc163 afc163 changed the base branch from master to feature Jun 26, 2019

@buildsize

This comment has been minimized.

Copy link

commented Jun 26, 2019

File name Previous Size New Size Change
package-lock.json 854.07 KB 839.16 KB -14.91 KB (2%)

@afc163 afc163 force-pushed the optimize-pageHeader-className-naming branch from c0fa2fc to 862cecf Jun 26, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 26, 2019

Codecov Report

Merging #17321 into feature will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17321      +/-   ##
===========================================
- Coverage    96.01%   95.96%   -0.06%     
===========================================
  Files          263      263              
  Lines         7377     7356      -21     
  Branches      2060     2054       -6     
===========================================
- Hits          7083     7059      -24     
- Misses         292      295       +3     
  Partials         2        2
Impacted Files Coverage Δ
components/page-header/index.tsx 100% <100%> (ø) ⬆️
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️
components/descriptions/index.tsx 98.66% <0%> (-0.27%) ⬇️
components/progress/Circle.tsx 100% <0%> (ø) ⬆️
components/drawer/index.tsx 98.73% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05feaeb...bdfcc91. Read the comment docs.

@afc163 afc163 requested review from chenshuai2144 and zombieJ Jun 26, 2019

@afc163 afc163 referenced this pull request Jun 27, 2019

Closed

use adjacent sibling combinator #17326

5 of 14 tasks complete
@afc163

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

@chenshuai2144 chenshuai2144 force-pushed the optimize-pageHeader-className-naming branch from dd185e3 to bdfcc91 Jun 27, 2019

@chenshuai2144

This comment has been minimized.

@afc163

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

来个 approve

@afc163

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

@chenshuai2144 @zombieJ 来个 approve

@afc163 afc163 merged commit 95c0a4e into feature Jun 28, 2019

23 checks passed

LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.01%)
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +3.98% compared to 05feaeb
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@delete-merged-branch delete-merged-branch bot deleted the optimize-pageHeader-className-naming branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.