Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Descriptions add vertical layout #17330

Merged
merged 4 commits into from Jun 27, 2019
Merged

feat: Descriptions add vertical layout #17330

merged 4 commits into from Jun 27, 2019

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Jun 27, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #16960

我想贴张图的 无奈 上传不上去

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Descriptions supports layout props.
🇨🇳 Chinese Descriptions支持layout属性

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #17330 into feature will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17330      +/-   ##
===========================================
+ Coverage    95.96%   95.97%   +0.01%     
===========================================
  Files          263      263              
  Lines         7359     7378      +19     
  Branches      2043     2022      -21     
===========================================
+ Hits          7062     7081      +19     
  Misses         295      295              
  Partials         2        2
Impacted Files Coverage Δ
components/descriptions/index.tsx 98.93% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d26675...2a9da95. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #17330 into feature will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17330      +/-   ##
===========================================
+ Coverage    95.96%   95.97%   +0.01%     
===========================================
  Files          263      263              
  Lines         7359     7378      +19     
  Branches      2043     2060      +17     
===========================================
+ Hits          7062     7081      +19     
  Misses         295      295              
  Partials         2        2
Impacted Files Coverage Δ
components/descriptions/index.tsx 98.93% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d26675...61318a1. Read the comment docs.

@@ -22,6 +22,7 @@ cols: 1
| bordered | 是否展示边框 | boolean | false |
| column | 一行的 `DescriptionItems` 数量,可以写成像素值或支持响应式的对象写法 `{ xs: 8, sm: 16, md: 24}` | number | 3 |
| size | 设置列表的大小。可以设置为 `middle` 、`small`, 或不填(只有设置 `bordered={true}` 生效) | `default | middle | small` | false |
| layout | 描述布局 | `horizontal | vertical` | 'horizontal' |
Copy link
Member

@afc163 afc163 Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

表格渲染有点问题

Copy link
Member Author

@hengkx hengkx Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

表格 是加上rowSpan 充满整行吗?

Copy link
Member

@afc163 afc163 Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是 API 表格渲染有问题。

ztplz
ztplz previously approved these changes Jun 27, 2019
components/descriptions/demo/vertical-border.md Outdated Show resolved Hide resolved
@hengkx
Copy link
Member Author

hengkx commented Jun 27, 2019

image
image

带边框的 好像有点问题 我在调整下

@hengkx
Copy link
Member Author

hengkx commented Jun 27, 2019

image

afc163
afc163 approved these changes Jun 27, 2019
@afc163 afc163 merged commit e1b8deb into ant-design:feature Jun 27, 2019
20 checks passed
@hengkx hengkx deleted the feature-desciption branch Jun 27, 2019
chenshuai2144 added a commit that referenced this issue Jun 28, 2019
issue in #17280 and #17330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants