Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Descriptions add vertical layout #17330

Merged
merged 4 commits into from Jun 27, 2019

Conversation

Projects
None yet
3 participants
@hengkx
Copy link
Contributor

commented Jun 27, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #16960

我想贴张图的 无奈 上传不上去

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English Descriptions supports layout props.
🇨🇳 Chinese Descriptions支持layout属性

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Jun 27, 2019

@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@codecov

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

Merging #17330 into feature will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17330      +/-   ##
===========================================
+ Coverage    95.96%   95.97%   +0.01%     
===========================================
  Files          263      263              
  Lines         7359     7378      +19     
  Branches      2043     2022      -21     
===========================================
+ Hits          7062     7081      +19     
  Misses         295      295              
  Partials         2        2
Impacted Files Coverage Δ
components/descriptions/index.tsx 98.93% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d26675...2a9da95. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

Merging #17330 into feature will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17330      +/-   ##
===========================================
+ Coverage    95.96%   95.97%   +0.01%     
===========================================
  Files          263      263              
  Lines         7359     7378      +19     
  Branches      2043     2060      +17     
===========================================
+ Hits          7062     7081      +19     
  Misses         295      295              
  Partials         2        2
Impacted Files Coverage Δ
components/descriptions/index.tsx 98.93% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d26675...61318a1. Read the comment docs.

@@ -22,6 +22,7 @@ cols: 1
| bordered | 是否展示边框 | boolean | false |
| column | 一行的 `DescriptionItems` 数量,可以写成像素值或支持响应式的对象写法 `{ xs: 8, sm: 16, md: 24}` | number | 3 |
| size | 设置列表的大小。可以设置为 `middle` 、`small`, 或不填(只有设置 `bordered={true}` 生效) | `default | middle | small` | false |
| layout | 描述布局 | `horizontal | vertical` | 'horizontal' |

This comment has been minimized.

Copy link
@afc163

afc163 Jun 27, 2019

Member

表格渲染有点问题

This comment has been minimized.

Copy link
@hengkx

hengkx Jun 27, 2019

Author Contributor

表格 是加上rowSpan 充满整行吗?

This comment has been minimized.

Copy link
@afc163

afc163 Jun 27, 2019

Member

是 API 表格渲染有问题。

@hengkx

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

image
image

带边框的 好像有点问题 我在调整下

@hengkx

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

image

@afc163

afc163 approved these changes Jun 27, 2019

@afc163 afc163 merged commit e1b8deb into ant-design:feature Jun 27, 2019

22 checks passed

LGTM analysis: JavaScript No new or fixed alerts
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No significant change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 95.96%)
Details
codecov/project 95.97% (+0.01%) compared to 6d26675
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@hengkx hengkx deleted the hengkx:feature-desciption branch Jun 27, 2019

chenshuai2144 added a commit that referenced this pull request Jun 28, 2019

update snap
issue in #17280 and #17330

@ilanus ilanus referenced this pull request Jul 7, 2019

Closed

Descriptions: add vertical / horizontal layout prop #16960

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.