Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Descriptions组件不设置label的显示问题 #17337

Merged
merged 2 commits into from Jun 27, 2019

Conversation

Projects
None yet
2 participants
@kairi1227
Copy link

commented Jun 27, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17290

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

xuqiang added some commits Jun 27, 2019

xuqiang
@tests-checker
Copy link

left a comment

Could you please add tests to make sure this change works as expected?

@netlify

This comment has been minimized.

Copy link

commented Jun 27, 2019

Deploy preview for ant-design ready!

Built with commit 6575501

https://deploy-preview-17337--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

Merging #17337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17337   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7351     7351           
  Branches     2015     2042   +27     
=======================================
  Hits         7054     7054           
  Misses        295      295           
  Partials        2        2
Impacted Files Coverage Δ
components/descriptions/index.tsx 98.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4463d24...6575501. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

Merging #17337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17337   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7351     7351           
  Branches     2015     2042   +27     
=======================================
  Hits         7054     7054           
  Misses        295      295           
  Partials        2        2
Impacted Files Coverage Δ
components/descriptions/index.tsx 98.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4463d24...6575501. Read the comment docs.

@afc163 afc163 changed the title Fix Descriptions组件不设置label的显示问题 #17290 fix: Descriptions组件不设置label的显示问题 Jun 27, 2019

@afc163 afc163 merged commit b0fb533 into ant-design:master Jun 27, 2019

25 of 27 checks passed

Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 216 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 4463d24...6575501
Details
codecov/project 95.95% remains the same compared to 4463d24
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 referenced this pull request Jun 29, 2019

Closed

add 3.20.0 changelog #17362

5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.