Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CheckboxGroup onChange 值保持选项的顺序 #17342

Merged
merged 5 commits into from Jun 28, 2019

Conversation

yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jun 27, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17297

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese CheckboxGroup onChange 值保持选项的顺序

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

@netlify netlify bot commented Jun 27, 2019

Deploy preview for ant-design processing.

Building with commit 612bf82

https://app.netlify.com/sites/ant-design/deploys/5d158577e062e600099eb3f1

@codecov
Copy link

@codecov codecov bot commented Jun 28, 2019

Codecov Report

Merging #17342 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17342      +/-   ##
==========================================
+ Coverage   95.95%   95.96%   +<.01%     
==========================================
  Files         263      263              
  Lines        7351     7357       +6     
  Branches     2042     2053      +11     
==========================================
+ Hits         7054     7060       +6     
  Misses        295      295              
  Partials        2        2
Impacted Files Coverage Δ
components/checkbox/Group.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e653b...50f6b9c. Read the comment docs.

@codecov
Copy link

@codecov codecov bot commented Jun 28, 2019

Codecov Report

Merging #17342 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17342      +/-   ##
==========================================
+ Coverage   95.95%      96%   +0.04%     
==========================================
  Files         263      263              
  Lines        7351     7357       +6     
  Branches     2042     2055      +13     
==========================================
+ Hits         7054     7063       +9     
+ Misses        295      292       -3     
  Partials        2        2
Impacted Files Coverage Δ
components/checkbox/Group.tsx 100% <100%> (ø) ⬆️
components/_util/wave.tsx 88.67% <0%> (+2.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30e653b...612bf82. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Jun 28, 2019

要补个用例。

@afc163 afc163 changed the title CheckboxGroup onChange 值保持选项的顺序 fix: CheckboxGroup onChange 值保持选项的顺序 Jun 28, 2019
@yoyo837
Copy link
Contributor Author

@yoyo837 yoyo837 commented Jun 28, 2019

这个 check 求指导...

@afc163 afc163 merged commit b5d16a6 into ant-design:master Jun 28, 2019
28 checks passed
@yoyo837 yoyo837 deleted the checkbox-onchange-sort branch Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants